You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/03 04:47:22 UTC
[GitHub] [arrow] vibhatha opened a new pull request, #13496: Minor: [C++] Aggregate doc fix
vibhatha opened a new pull request, #13496:
URL: https://github.com/apache/arrow/pull/13496
The `Aggregate` was exposed to the user, but the docs weren't properly fixed to reflect that. Adding that minor change in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13496: MINOR: [C++] Aggregate doc fix
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13496:
URL: https://github.com/apache/arrow/pull/13496#issuecomment-1173011124
cc @lidavidm @westonpace please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13496: MINOR: [C++] Aggregate doc fix
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13496:
URL: https://github.com/apache/arrow/pull/13496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13496: MINOR: [C++] Aggregate doc fix
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13496:
URL: https://github.com/apache/arrow/pull/13496#issuecomment-1173756448
Sorry, I don't see what the point of the change is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13496: Minor: [C++] Aggregate doc fix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13496:
URL: https://github.com/apache/arrow/pull/13496#issuecomment-1173011103
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #13496: MINOR: [C++] Aggregate doc fix
Posted by GitBox <gi...@apache.org>.
vibhatha commented on PR #13496:
URL: https://github.com/apache/arrow/pull/13496#issuecomment-1174477515
Ah I moved the `Aggregate` code block within the `/// @}` range to make this included in the docs. So `Aggregate` becomes a click-able and easy to navigate to its definition if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org