You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/05 20:04:46 UTC

[GitHub] [bookkeeper] hsaputra commented on a change in pull request #2758: state store: getStream: log stream info

hsaputra commented on a change in pull request #2758:
URL: https://github.com/apache/bookkeeper/pull/2758#discussion_r683751734



##########
File path: stream/storage/impl/src/main/java/org/apache/bookkeeper/stream/storage/impl/metadata/RootRangeStoreImpl.java
##########
@@ -80,7 +80,7 @@
     /**
      * ns name key: [NS_NAME_TAG][ns_name].
      */
-    static final byte[] getNamespaceNameKey(String nsName) {
+    static byte[] getNamespaceNameKey(String nsName) {

Review comment:
       Removing the "final" here just refactor since not needed for static methods?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org