You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2017/08/10 17:34:08 UTC
Review Request 61562: GEODE-3423: Provide support for running parallel
docker builds in Jenkins
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Mark Bretl.
Repository: geode
Description
-------
- Also cleaning up other Dockerfiles which are unused
Signed-off-by: Scott Jewell <sj...@pivotal.io>
Diffs
-----
dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685
dev-tools/docker/base/build-base-docker.sh 9aab72c45d63c519874ad39aaf74c8236d9671ed
dev-tools/docker/compile/Dockerfile 6ae343a70eccf7cc4b303228118cee0b8579e79a
dev-tools/docker/compile/start-compile-docker.sh 9059c5b5bbffbadaa82277c05e2189360d94a484
gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e
Diff: https://reviews.apache.org/r/61562/diff/1/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 61562: GEODE-3423: Provide support for running
parallel docker builds in Jenkins
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/#review182621
-----------------------------------------------------------
dev-tools/docker/base/Dockerfile
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/61562/#comment258593>
We can't embedd/redistribute the Oracle JDK due to licensing. We should use the openjdk:8 as a base image (see https://hub.docker.com/_/openjdk/).
- Anthony Baker
On Aug. 10, 2017, 5:34 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61562/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 5:34 p.m.)
>
>
> Review request for geode, Anthony Baker and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Also cleaning up other Dockerfiles which are unused
>
> Signed-off-by: Scott Jewell <sj...@pivotal.io>
>
>
> Diffs
> -----
>
> dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685
> dev-tools/docker/base/build-base-docker.sh 9aab72c45d63c519874ad39aaf74c8236d9671ed
> dev-tools/docker/compile/Dockerfile 6ae343a70eccf7cc4b303228118cee0b8579e79a
> dev-tools/docker/compile/start-compile-docker.sh 9059c5b5bbffbadaa82277c05e2189360d94a484
> gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e
>
>
> Diff: https://reviews.apache.org/r/61562/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 61562: GEODE-3423: Provide support for running
parallel docker builds in Jenkins
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/#review182715
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On Aug. 10, 2017, 9:16 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61562/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 9:16 p.m.)
>
>
> Review request for geode, Anthony Baker and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Also cleaning up other Dockerfiles which are unused
>
> Signed-off-by: Scott Jewell <sj...@pivotal.io>
>
>
> Diffs
> -----
>
> dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685
> dev-tools/docker/base/build-base-docker.sh 9aab72c45d63c519874ad39aaf74c8236d9671ed
> dev-tools/docker/compile/Dockerfile 6ae343a70eccf7cc4b303228118cee0b8579e79a
> dev-tools/docker/compile/start-compile-docker.sh 9059c5b5bbffbadaa82277c05e2189360d94a484
> gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e
>
>
> Diff: https://reviews.apache.org/r/61562/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 61562: GEODE-3423: Provide support for running
parallel docker builds in Jenkins
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61562/
-----------------------------------------------------------
(Updated Aug. 10, 2017, 9:16 p.m.)
Review request for geode, Anthony Baker and Mark Bretl.
Changes
-------
Switched to openjdk as base image
Repository: geode
Description
-------
- Also cleaning up other Dockerfiles which are unused
Signed-off-by: Scott Jewell <sj...@pivotal.io>
Diffs (updated)
-----
dev-tools/docker/base/Dockerfile 1cce0ddb0d29c9e188d27481c82123e357c5b685
dev-tools/docker/base/build-base-docker.sh 9aab72c45d63c519874ad39aaf74c8236d9671ed
dev-tools/docker/compile/Dockerfile 6ae343a70eccf7cc4b303228118cee0b8579e79a
dev-tools/docker/compile/start-compile-docker.sh 9059c5b5bbffbadaa82277c05e2189360d94a484
gradle/docker.gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e
Diff: https://reviews.apache.org/r/61562/diff/2/
Changes: https://reviews.apache.org/r/61562/diff/1-2/
Testing
-------
Thanks,
Jens Deppe