[GitHub] [druid] paul-rogers commented on pull request #13553: Use template file for adding table functions grammar

[GitBox <gi...@apache.org>]

paul-rogers commented on PR #13553:
URL: https://github.com/apache/druid/pull/13553#issuecomment-1347050635

   The one draw-back to the copy-and-edit approach is that each Calcite upgrade requires a manual step to match up our version against the new Calcite version, and to understand the difference between any Calcite changes and our own. The edit script was meant to automate that process. But, it is fine to make it a manual process, since we seldom upgrade Calcite. (Note, however, that there is an open PR to do just that: to upgrade Calcite.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org