[GitHub] [arrow] wjones127 commented on a diff in pull request #14632: MINOR: [Docs][C++] Improve docs for ConcatenateTables

[GitBox <gi...@apache.org>]

wjones127 commented on code in PR #14632:
URL: https://github.com/apache/arrow/pull/14632#discussion_r1021752988


##########
cpp/src/arrow/table.h:
##########
@@ -286,7 +286,23 @@ struct ARROW_EXPORT ConcatenateTablesOptions {
   static ConcatenateTablesOptions Defaults() { return {}; }
 };
 
-/// \brief Construct table from multiple input tables.
+/// \brief Construct a new table from multiple input tables.
+///
+/// The new table is assembled from existing column chunks without copying,
+/// if schemas are identical. If schemas do not match exactly, an attempt is
+/// made to unify them, and then column chunks are converted to their
+/// respective unified datatype, which will probably incur a copy.
+/// :func:`arrow::PromoteTableToSchema` is used to unify schemas.

Review Comment:
   Schemas will only be unified if requested.
   
   ```suggestion
   /// if schemas are identical. If schemas do not match exactly and 
   /// unifySchemas is enabled in options (off by default), an attempt is
   /// made to unify them, and then column chunks are converted to their
   /// respective unified datatype, which will probably incur a copy.
   /// :func:`arrow::PromoteTableToSchema` is used to unify schemas.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org