You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/29 16:12:00 UTC
[jira] [Commented] (NIFI-5352) Change distribution to have the JARs
and NARs in lib readable by "other"
[ https://issues.apache.org/jira/browse/NIFI-5352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527893#comment-16527893 ]
ASF GitHub Bot commented on NIFI-5352:
--------------------------------------
GitHub user lfrancke opened a pull request:
https://github.com/apache/nifi/pull/2825
NIFI-5352 Change distribution to have the JARs and NARs in lib readable by "other"
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lfrancke/nifi NIFI-5352
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2825.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2825
----
commit d3b1694c4e77165a5ff87b0dc0be98a1ed86cd0d
Author: Lars Francke <la...@...>
Date: 2018-06-29T16:09:36Z
NIFI-5352 Change distribution to have the JARs and NARs in lib readable by "other"
----
> Change distribution to have the JARs and NARs in lib readable by "other"
> ------------------------------------------------------------------------
>
> Key: NIFI-5352
> URL: https://issues.apache.org/jira/browse/NIFI-5352
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 1.7.0
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
>
> Currently all the nar and jar files under {{lib}} and {{lib/boostrap}} have the 640 permissions. That means it can't even be read by "other".
> When I extract it as "root" but want to run as "nifi" this causes it to fail because the "nifi" user cannot read the jar files.
> I don't think there's a particular harm in having others being able to read those files. So I'd like to change the assembly to include those as 644 if there are no objections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)