You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/02 10:36:11 UTC
[GitHub] [maven] gnodet opened a new pull request, #894: [MNG-7616] Fix missing exported artifacts
gnodet opened a new pull request, #894:
URL: https://github.com/apache/maven/pull/894
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #894:
URL: https://github.com/apache/maven/pull/894#discussion_r1038069370
##########
maven-core/src/main/resources/META-INF/maven/extension.xml:
##########
@@ -136,6 +136,16 @@ under the License.
</exportedPackages>
<exportedArtifacts>
+ <!-- maven 4 api -->
+ <exportedArtifact>org.apache.maven:maven-api-core</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-meta</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-model</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-settings</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-toolchain</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-xml</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-xml-impl</exportedArtifact>
+ <exportedArtifact>org.apache.maven:plexus-utils</exportedArtifact>
Review Comment:
I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also no listed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #894:
URL: https://github.com/apache/maven/pull/894#issuecomment-1335054922
@cstamas I think a few resolver artifacts are missing, but I'm not even sure they are part of the default class loader. Could you double check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #894:
URL: https://github.com/apache/maven/pull/894#discussion_r1038069370
##########
maven-core/src/main/resources/META-INF/maven/extension.xml:
##########
@@ -136,6 +136,16 @@ under the License.
</exportedPackages>
<exportedArtifacts>
+ <!-- maven 4 api -->
+ <exportedArtifact>org.apache.maven:maven-api-core</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-meta</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-model</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-settings</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-toolchain</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-xml</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-xml-impl</exportedArtifact>
+ <exportedArtifact>org.apache.maven:plexus-utils</exportedArtifact>
Review Comment:
I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also not listed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #894:
URL: https://github.com/apache/maven/pull/894#issuecomment-1335237275
> @cstamas I think a few resolver artifacts are missing, but I'm not even sure they are part of the default class loader. Could you double check ?
Nope, all good, connector and transport is not part of public api, they were never published
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #894:
URL: https://github.com/apache/maven/pull/894#discussion_r1038069370
##########
maven-core/src/main/resources/META-INF/maven/extension.xml:
##########
@@ -136,6 +136,16 @@ under the License.
</exportedPackages>
<exportedArtifacts>
+ <!-- maven 4 api -->
+ <exportedArtifact>org.apache.maven:maven-api-core</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-meta</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-model</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-settings</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-toolchain</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-xml</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-xml-impl</exportedArtifact>
+ <exportedArtifact>org.apache.maven:plexus-utils</exportedArtifact>
Review Comment:
I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also not listed here. IIUC then listing an artifact here makes it impossible to add it explicitly to the class loader hierarchy (for a plugin or build extension)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #894:
URL: https://github.com/apache/maven/pull/894#discussion_r1038100207
##########
maven-core/src/main/resources/META-INF/maven/extension.xml:
##########
@@ -136,6 +136,16 @@ under the License.
</exportedPackages>
<exportedArtifacts>
+ <!-- maven 4 api -->
+ <exportedArtifact>org.apache.maven:maven-api-core</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-meta</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-model</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-settings</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-toolchain</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-api-xml</exportedArtifact>
+ <exportedArtifact>org.apache.maven:maven-xml-impl</exportedArtifact>
+ <exportedArtifact>org.apache.maven:plexus-utils</exportedArtifact>
Review Comment:
Good point. I've also removed the `maven-xml-impl` for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #894: [MNG-7616] Fix missing exported artifacts
Posted by GitBox <gi...@apache.org>.
gnodet merged PR #894:
URL: https://github.com/apache/maven/pull/894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org