You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/09/26 13:17:57 UTC

[GitHub] [openwhisk] nitikagarw commented on a change in pull request #4968: Controller should not return a payload for created and deleted entities

nitikagarw commented on a change in pull request #4968:
URL: https://github.com/apache/openwhisk/pull/4968#discussion_r495455996



##########
File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/ApiUtils.scala
##########
@@ -341,7 +342,7 @@ trait WriteOps extends Directives {
     }) {
       case Success(entity) =>
         logging.debug(this, s"[PUT] entity success")
-        postProcess map { _(entity) } getOrElse complete(OK, entity)
+        postProcess map { _(entity) } getOrElse complete(OK)

Review comment:
       Hi @style95, Thank you for the review. I have added the feature flag for this change. 
   So, now I should revert the test files to the previous behaviour, is that correct? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org