[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1773: [CELEBORN-852] Adding new metrics to record the number of registered …

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1773:
URL: https://github.com/apache/incubator-celeborn/pull/1773#discussion_r1278897422


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala:
##########
@@ -94,6 +95,8 @@ object WorkerSource {
   // slots
   val SLOTS_ALLOCATED = "SlotsAllocated"
 
+  val ACTIVE_CONNECTION_COUNT = "ActiveConnectionCount"

Review Comment:
   Could you also add this metric in `celeborn-dashboard.json`?



##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -257,6 +257,20 @@ abstract class AbstractSource(conf: CelebornConf, role: String)
     }
   }
 
+  override def decCounter(metricsName: String, decV: Long = 1): Unit = {

Review Comment:
   Shall we just call `incCounter(xxx, -1)` to achieve this functionality, so we don't need to add these methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org