[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173848822


##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleMaster.java:
##########
@@ -238,18 +240,19 @@ public void close() throws Exception {
     ThreadUtils.shutdownExecutors(10, executor);
   }
 
-  private ShuffleTask encodeExternalShuffleTask(
+  private ShuffleResourceDescriptor genShuffleResourceDescriptor(

Review Comment:
   No, same like attemptId, so i remove mapattemptId->attemptIdIndex map as same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org