[jira] [Commented] (SOLR-11810) Upgrade Jetty to 9.4.x

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324768#comment-16324768 ] 

Erick Erickson commented on SOLR-11810:
---------------------------------------

All tests pass. I'll pound this over the weekend with some of the slower options turned on and commit probably Monday unless

1> there are objections
2> I find some issues

It seems like a good time to commit as we'll get some mileage on this before 7.3.

Do note that I was testing a couple of issues and I could reliably reproduce bogus update failures/recoveries and with this patch they would no longer reproduce so there are practical reasons to upgrade.

> Upgrade Jetty to 9.4.x 
> -----------------------
>
>                 Key: SOLR-11810
>                 URL: https://issues.apache.org/jira/browse/SOLR-11810
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Assignee: Erick Erickson
>         Attachments: SOLR-11810.patch, SOLR-11810.patch
>
>
> Jetty 9.4.x was released over a year back : https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00097.html .  Solr doesn't use any of the major improvements listed on the announce thread but it's the version that's in active development. 
> We should upgrade to Jetty 9.4.x series from 9.3.x
> The latest version right now is 9.4.8.v20171121 . Upgrading it locally required a few compile time changes only. 
> Under "Default Sessions" in https://www.eclipse.org/jetty/documentation/9.4.x/upgrading-jetty.html#_upgrading_from_jetty_9_3_x_to_jetty_9_4_0  it states that "In previous versions of Jetty this was referred to as "hash" session management." . 
> The patch fixes all the compile time issues.
> Currently two tests are failing:
> TestRestManager
> TestManagedSynonymGraphFilterFactory
> Steps to upgrade the Jetty version were :
> 1. Modify {{ivy-versions.properties}} to reflect the new version number
> 2. Run {{ant jar-checksums}} to generate new JAR checksums



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org