[GitHub] spark pull request #21736: [SPARK-24782][SQL] Simplify conf retrieval in SQL...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21736#discussion_r201733128
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ---
    @@ -89,15 +89,9 @@ trait BinaryArrayExpressionWithImplicitCast extends BinaryExpression
           > SELECT _FUNC_(NULL);
            -1
       """)
    -case class Size(
    -    child: Expression,
    -    legacySizeOfNull: Boolean)
    -  extends UnaryExpression with ExpectsInputTypes {
    +case class Size(child: Expression) extends UnaryExpression with ExpectsInputTypes {
     
    -  def this(child: Expression) =
    -    this(
    -      child,
    -      legacySizeOfNull = SQLConf.get.getConf(SQLConf.LEGACY_SIZE_OF_NULL))
    +  val legacySizeOfNull = SQLConf.get.legacySizeOfNull
    --- End diff --
    
    Actually we can do this even without my executor-side SQLConf change: the conf value will be determined at driver side during expression creation and serialized/sent to executors...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org