You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/02/02 22:37:02 UTC
Review Request 43110: GEODE-894 / 895 / 896
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43110/
-----------------------------------------------------------
Review request for geode, Darrel Schneider and Kirk Lund.
Repository: geode
Description
-------
GEODE-894: Remove unused concurrency utilities
GEODE-895: Add CompactConcurrentHashSet2 to LICENSE
CompactConcurrentHashSet2 is derived from JSR-166 code available
in the public domain. This should be noted in the LICENSE file
just like a permissively licensed BSD/MIT dependency.
GEODE-896: Update source NOTICE with log4j declaration
GemFireParameterizedMessage is based on a log4j class,
ParameterizedMessage. This needs to be added to the NOTICE file.
Diffs
-----
LICENSE 61afe151f686d8a066adcd5de722eab1ae1d3a66
NOTICE 3f5dd074532e7b8a6ebc5a6bd9cfbc67081d5841
gemfire-assembly/src/main/dist/LICENSE 66d55bfabcb2e54dbcd41e79f1aa287e2e771d67
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/GFEAbstractQueuedSynchronizer.java 389bca9beab634c99193fdd87433471d4c5c2a81
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/ReentrantReadWriteWriteShareLock.java 6a1800a638fe5d472c47f75698b7cf16fd9b099e
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/locks/ReentrantReadWriteWriteShareLockJUnitTest.java 1781ed3792d8a5169c653a16882002cc65d9c00b
Diff: https://reviews.apache.org/r/43110/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 43110: GEODE-894 / 895 / 896
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43110/#review117862
-----------------------------------------------------------
Ship it!
You might want to also include GemFireParameterizedMessageFactory when you mention GemFireParameterizedMessage. Both are based on log4j classes.
- Kirk Lund
On Feb. 2, 2016, 9:37 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43110/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 9:37 p.m.)
>
>
> Review request for geode, Darrel Schneider and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-894: Remove unused concurrency utilities
>
> GEODE-895: Add CompactConcurrentHashSet2 to LICENSE
>
> CompactConcurrentHashSet2 is derived from JSR-166 code available
> in the public domain. This should be noted in the LICENSE file
> just like a permissively licensed BSD/MIT dependency.
>
> GEODE-896: Update source NOTICE with log4j declaration
>
> GemFireParameterizedMessage is based on a log4j class,
> ParameterizedMessage. This needs to be added to the NOTICE file.
>
>
> Diffs
> -----
>
> LICENSE 61afe151f686d8a066adcd5de722eab1ae1d3a66
> NOTICE 3f5dd074532e7b8a6ebc5a6bd9cfbc67081d5841
> gemfire-assembly/src/main/dist/LICENSE 66d55bfabcb2e54dbcd41e79f1aa287e2e771d67
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/GFEAbstractQueuedSynchronizer.java 389bca9beab634c99193fdd87433471d4c5c2a81
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/ReentrantReadWriteWriteShareLock.java 6a1800a638fe5d472c47f75698b7cf16fd9b099e
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/locks/ReentrantReadWriteWriteShareLockJUnitTest.java 1781ed3792d8a5169c653a16882002cc65d9c00b
>
> Diff: https://reviews.apache.org/r/43110/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 43110: GEODE-894 / 895 / 896
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43110/#review117541
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Feb. 2, 2016, 1:37 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43110/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 1:37 p.m.)
>
>
> Review request for geode, Darrel Schneider and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-894: Remove unused concurrency utilities
>
> GEODE-895: Add CompactConcurrentHashSet2 to LICENSE
>
> CompactConcurrentHashSet2 is derived from JSR-166 code available
> in the public domain. This should be noted in the LICENSE file
> just like a permissively licensed BSD/MIT dependency.
>
> GEODE-896: Update source NOTICE with log4j declaration
>
> GemFireParameterizedMessage is based on a log4j class,
> ParameterizedMessage. This needs to be added to the NOTICE file.
>
>
> Diffs
> -----
>
> LICENSE 61afe151f686d8a066adcd5de722eab1ae1d3a66
> NOTICE 3f5dd074532e7b8a6ebc5a6bd9cfbc67081d5841
> gemfire-assembly/src/main/dist/LICENSE 66d55bfabcb2e54dbcd41e79f1aa287e2e771d67
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/GFEAbstractQueuedSynchronizer.java 389bca9beab634c99193fdd87433471d4c5c2a81
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/locks/ReentrantReadWriteWriteShareLock.java 6a1800a638fe5d472c47f75698b7cf16fd9b099e
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/locks/ReentrantReadWriteWriteShareLockJUnitTest.java 1781ed3792d8a5169c653a16882002cc65d9c00b
>
> Diff: https://reviews.apache.org/r/43110/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>