You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/08 05:22:24 UTC
[GitHub] [spark] zhengruifeng commented on a change in pull request #27818:
[SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
zhengruifeng commented on a change in pull request #27818: [SPARK-30929][ML] ML, GraphX 3.0 QA: API: New Scala APIs, docs
URL: https://github.com/apache/spark/pull/27818#discussion_r389336697
##########
File path: mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
##########
@@ -195,7 +195,8 @@ class AFTSurvivalRegression @Since("1.6.0") (@Since("1.6.0") override val uid: S
}
@Since("3.0.0")
Review comment:
If we can safely mark it protected, then do not need this since annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org