[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting

[GitBox <gi...@apache.org>]

mdmarshmallow commented on code in PR #929:
URL: https://github.com/apache/lucene/pull/929#discussion_r894746323


##########
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##########
@@ -74,7 +74,7 @@ public FacetResult getTopChildren(int topN, String dim, String... path) throws I
 
   @Override
   public Number getSpecificValue(String dim, String... path) throws IOException {
-    if (path.length != 1) {
+    if (stateConfig.getDimConfig(dim).hierarchical == false && path.length != 1) {
       throw new IllegalArgumentException("path must be length=1");

Review Comment:
   Maybe we should update this error message? Something like `dim + "is not configured to be hierarchical, path must be length=1"`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org