You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/06/13 18:57:02 UTC

[jira] [Commented] (HADOOP-10678) SecurityUtil has unnecessary synchronization on collection used for only tests

    [ https://issues.apache.org/jira/browse/HADOOP-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030839#comment-14030839 ] 

Hudson commented on HADOOP-10678:
---------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #5699 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5699/])
HADOOP-10678. SecurityUtil has unnecessary synchronization on collection used for only tests. Contributed by Benoy Antony. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1602473)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java


> SecurityUtil has unnecessary synchronization on collection used for only tests
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-10678
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10678
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>             Fix For: 3.0.0, 2.5.0
>
>         Attachments: HADOOP-10678.patch, HADOOP-10678.patch
>
>
> The function _SecurityUtil.getKerberosInfo()_  is a function used during authentication and authorization. 
> It has two synchronized blocks and one of them is on testProviders. This is an unnecessary lock given that the testProviders is empty in real scenario.



--
This message was sent by Atlassian JIRA
(v6.2#6252)