You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/02 05:18:21 UTC

[GitHub] [incubator-yunikorn-web] sunilgovind commented on a change in pull request #38: YUNIKORN-46: Add a quick search box in app page

sunilgovind commented on a change in pull request #38:
URL: https://github.com/apache/incubator-yunikorn-web/pull/38#discussion_r433625156



##########
File path: src/app/components/apps-view/apps-view.component.html
##########
@@ -17,6 +17,25 @@
  -->
 
 <div class="apps-view">
+  <mat-form-field class="search-wrapper white-mat-form-field">

Review comment:
       I agree. I remember some old Ui where each column search were there, In YARN UI2, we have a regex based search. Is it similar here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org