You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ha...@apache.org on 2018/05/31 21:30:20 UTC

[royale-asjs] branch feature/revert-refactor updated: Remove Slider class selectors

This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch feature/revert-refactor
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/feature/revert-refactor by this push:
     new a8ca8b5  Remove Slider class selectors
a8ca8b5 is described below

commit a8ca8b5a3c0499ccd0df398bafa5b6a14bda09c3
Author: Harbs <ha...@in-tools.com>
AuthorDate: Fri Jun 1 00:30:12 2018 +0300

    Remove Slider class selectors
---
 frameworks/projects/Basic/src/main/resources/defaults.css           | 6 ------
 .../src/main/royale/org/apache/royale/html/beads/SliderView.as      | 2 ++
 manualtests/RoyaleTest_Panel/src/MyInitialView.mxml                 | 2 +-
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/frameworks/projects/Basic/src/main/resources/defaults.css b/frameworks/projects/Basic/src/main/resources/defaults.css
index 5a515d6..b262dce 100644
--- a/frameworks/projects/Basic/src/main/resources/defaults.css
+++ b/frameworks/projects/Basic/src/main/resources/defaults.css
@@ -598,12 +598,6 @@ Slider
 	IBeadController: ClassReference("org.apache.royale.html.beads.controllers.HSliderMouseController");
 	position: relative;
 }
-.SliderTrack {
-	position: absolute;
-}
-.SliderThumb {
-	position: absolute;
-}
 
 Spinner
 {
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/SliderView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/SliderView.as
index 070fa2a..e5765ef 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/SliderView.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/SliderView.as
@@ -100,10 +100,12 @@ package org.apache.royale.html.beads
 			COMPILE::JS {
 				_track = new Button();
 				_track.className = "SliderTrack";
+				_track.style = {"position": "absolute", "padding" : 0};
 				host.addElement(_track);
 				
 				_thumb = new TextButton();
 				_thumb.className = "SliderThumb";
+				_thumb.style = {"position" : "absolute", "padding" : 0};
 				_thumb.text = '\u29BF';
 				host.addElement(_thumb);
 			}
diff --git a/manualtests/RoyaleTest_Panel/src/MyInitialView.mxml b/manualtests/RoyaleTest_Panel/src/MyInitialView.mxml
index 5af7baf..861a1c0 100644
--- a/manualtests/RoyaleTest_Panel/src/MyInitialView.mxml
+++ b/manualtests/RoyaleTest_Panel/src/MyInitialView.mxml
@@ -152,7 +152,7 @@ limitations under the License.
 		<js:Spacer height="10" />
 		<js:Label id="slideMe" text="slider value" />
 		<js:Label id="slideMe2" text="{slider.value}" />
-		<js:Slider id="slider" width="200"
+		<js:Slider id="slider" width="200" height="15"
 					  valueChange="sliderChanged(slider)"
 					  minimum="0"
 					  maximum="100"

-- 
To stop receiving notification emails like this one, please contact
harbs@apache.org.