[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #655: MINIFICPP-1049 - Fix make docker

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #655: MINIFICPP-1049 - Fix make docker
URL: https://github.com/apache/nifi-minifi-cpp/pull/655#discussion_r329820428
 
 

 ##########
 File path: docker/DockerBuild.sh
 ##########
 @@ -31,12 +31,13 @@ echo "CMake Source Directory: $CMAKE_SOURCE_DIR"
 echo "MiNiFi Package: $MINIFI_SOURCE_CODE"
 
 # Copy the MiNiFi source tree to the Docker working directory before building
+rm -rf $CMAKE_SOURCE_DIR/docker/minificppsource
 mkdir -p $CMAKE_SOURCE_DIR/docker/minificppsource
 rsync -avr \
       --exclude '/*build*' \
       --exclude '/*_repository*' \
       --exclude '/logs' \
-      --exclude '/cmake' \
+      --exclude '/cmake-build-*' \
 
 Review comment:
   I wanted to avoid uploading CMakeCache and cmake-build-debug to the container, thanks for fixing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services