You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2024/04/05 19:45:21 UTC
[PR] Update GraalJS to 23.0.3 [netbeans]
matthiasblaesing opened a new pull request, #7248:
URL: https://github.com/apache/netbeans/pull/7248
Closes: #7245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1560260637
##########
.github/workflows/main.yml:
##########
@@ -249,18 +249,6 @@ jobs:
- name: Commit Validation tests
run: .github/retry.sh ant $OPTS -Dcluster.config=$CLUSTER_CONFIG commit-validation
- - name: Set up JDK 11 for core.network
- uses: actions/setup-java@v4
- if: matrix.java == 17 && success()
- with:
- java-version: 11
- distribution: ${{ env.default_java_distribution }}
-
- # TODO fails on 17+
- - name: platform/core.network
- if: matrix.java == 17 && success()
- run: ant $OPTS -f platform/core.network test
-
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2043521463
@entlicher what is the graal-sdk JDK compatibility matrix? Version 24.0.0 sounds like it is using the old, non-jdk versioning scheme?
https://github.com/apache/netbeans/pull/7248#issuecomment-2041558915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2045087308
@matthiasblaesing I'd like to participate on fixing the tests -- can I push changes to your branch, or would you prefer a separate branch over your PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2051016252
I do not entirely think that GraalVM is an 'exerimental' technology ... but anyway, I think there are still some issues:
- published module (libs.truffleapi) is dropped that declares **public** packages, which might break some projects. This should be done for a reason only and if, then `module_auto_deps` should be used to maintain binary compatibility.
- drops the possibility to go along two paths: consume JDK services and provide bundled ones; this is because drop of `libs.graalsdk.system` from the start. Reasons not well explained. If it can be fixed, it would be fair to drop this "dichotomy" when GraalVM for JDK 17 goes EOL or NB stops supporting JDK17, whichever comes first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2047677737
@matthiasblaesing I probably do not have enough context, sorry .... what issue was addressed by setting
```
System.setProperty( "polyglot.engine.WarnInterpreterOnly", "false" ); //NOI18N
System.setProperty( "truffle.UseFallbackRuntime", "true" ); //NOI18N
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2047831999
_Our_ current roadmap has JDK 17 supported until 3/2026, and I'm not entirely sure where any decision on running on GraalVM fits into that either.
@mbien am I right in thinking that running the scripting tests on JDK 22 would have picked up the reported issue earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1557001429
##########
ide/libs.graalsdk/external/binaries-list:
##########
@@ -14,5 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0
-8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0
+8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0
Review Comment:
Technically, `graal-sdk` may not be needed - it seems to be just a placeholder package, and the original packages probably have been split up into some of the other bundles here.
As a side note, maybe there's a better name for the module? maybe `libs.graal`?
##########
ide/libs.graalsdk/external/binaries-list:
##########
@@ -14,5 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0
-8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0
+8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0
+06055903437576484DCC6545AF995FF67E0A3B55 org.graalvm.sdk:launcher-common:24.0.0
+335646EC205A3BCE0D518748D08A5C45900A9869 org.graalvm.shadowed:jline:24.0.0
Review Comment:
I guess the license file for JLine is not present (which may be reason why the paperwork job failed). (And I don't think pure UPL would be the correct license for that.)
##########
webcommon/libs.graaljs/external/js-23.0.3-license.txt:
##########
@@ -2,8 +2,8 @@ Name: Graal SDK and Truffle API
Description: Graal SDK and Truffle API
Review Comment:
Nit: please rename the file to `...-24.0.0-...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1559528716
##########
ide/libs.graalsdk/external/binaries-list:
##########
@@ -14,5 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0
-8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0
+8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0
+06055903437576484DCC6545AF995FF67E0A3B55 org.graalvm.sdk:launcher-common:24.0.0
+335646EC205A3BCE0D518748D08A5C45900A9869 org.graalvm.shadowed:jline:24.0.0
Review Comment:
Fixed in #7253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2048112509
FYI - tests enabled in this PR are green in #7253, ready to merge into this one, after review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2052332444
@matthiasblaesing understood... I planned to work on this today, but other schedule creeped in, so I hope I'll do something over the weekend to have a stable thing (or a failure ;)) before branching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2047590795
I am also slightly concerned with removal of the GraalVM testsuites. The recent GraalVM for JDK21 has dropped builtin JS support, so that's fine. But GraalVM for JDK17 still has `js` as an installable component and according to the [roadmap](https://docs.oracle.com/en/graalvm/jdk/22/docs/release-calendar/index.html#planned-releases), JDK17 as LTS is to be supported until 9/2026 ...
If possible I'd prefer that test suite to be brought back, so it can ensure that NetBeans can smoothly run on GraalVM that includes JS support "in bootclasspath".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2049845681
Well. There are 3 possible cases with different versions / states of GraalVM.
Easiest: GraalVM **for JDK 21** or generally GraalVM JDKs of internal version greater (I hope) or equal to **23.1.0** -- these *do not contain* org.graalvm.sdk module at all, so Polyglot class API and truffle API is not available on the bootclassspath. No `gu` is provided to install optional components, so the user cannot change JDK state/configuration. Good. Nothing messes/mixes with our distributed libraries, so **GraalVM for JDK21, for JDK22* and any non-Graal JDK is OK.
Now GraalVM for JDK17, *without* JS installed. I did a bad job validating my changes. Because this combination fails:
```
Allowed engines: GraalVM:js,Graal.js,Nashorn
Found engines:
freemarker
NetBeans indentation
Will not resolve proxy configuration.
```
The GraalVM does not contain `javascript` implementation, but **does contain** Polyglot and Truffle classes. So provided that [`OpenIDE-Module-Hide-Classpath-Packages` was removed](https://github.com/apache/netbeans/pull/7248/commits/112fa4b83fe5f6e4bf0e98a6c53b77da8e8195df) - NetBeans will load the JDK-provided infrastructure for its libs.graalsdk `EngineProvider` impl. Those JDK classes do not care at all about that NetBeans provide some language implementation. JDK-provided Polyglot reports "no javascript", so there's none.
Third option, GraalVM for JDK17 (better: JDK with polyglot API) *and js installed in it*: things are fine - Jbecause JDK-provided JS implementation is loaded. Although that wasn't the exactly for why `libs.graalsdk` was implemented for: there once was `libs.graalsdk.system` that aimed to load strictly classes from the JDK, if there was any Polyglot available on bootstrap path. But - the test works, so OK.
Why the tests for `libs.graaljs` fail ? That's because they specifically test that that provided Javascript implementation is OK. It wasn't developet to test "just random" javascript implementation, picked from the environment, but the bundled one. The testsuite tries hard to load NetBeans classes, despite (feared) JDK-provided Polyglot API classes present in tests' JVM. So it loads the Polyglot API from the NetBeans. This is where the `Hide-Packages` and `libs.truffleapi` removal steps in: it will nicely load NB-distributed Polyglot API (because of special classloader is used) ... but when Polyglot itself attempts to use SerivceLoader classes to its own Truffle implementation by name ...
... the class is not exported (it was, in `libs.truffleapi`, but the relevant `Public-Packages` entry is not in this PR. So it is loaded from the JDK. And all weird stuff like interface mismatches, version mismatches etc happen.
So one way is to fix the test. It can run without the classloading wrapper on non-polyglot GraalVM _and_ on Polyglot + JS enabled GraalVM. It will not succeed on Polyglot JDK without JS as JS won't be enumerated by JDK. This also means that NB will not be able to bring its JS implementation working on Polyglot JDK without JS installed in it (= GraalVM for JDK17 and older GraalVMs, like 22.3 /JDK17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1554627935
##########
.github/workflows/main.yml:
##########
@@ -2618,9 +2618,9 @@ jobs:
- name: Setup GraalVM {{ matrix.graal }}
run: |
- URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java11-linux-amd64-${{ matrix.graal }}.tar.gz
+ URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java17-linux-amd64-${{ matrix.graal }}.tar.gz
curl -L $URL | tar -xz
- GRAALVM=`pwd`/graalvm-ce-java11-${{ matrix.graal }}
+ GRAALVM=`pwd`/graalvm-ce-java17-${{ matrix.graal }}
echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
Review Comment:
unfortunately this isn't going to work, please see:
https://github.com/apache/netbeans/issues/6925#issuecomment-2003319844
I think we should consider to start disabling tests until someone who is interested in polyglot features wants to look into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1559527907
##########
ide/libs.graalsdk/external/binaries-list:
##########
@@ -14,5 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-8E62643FD621053E00EE52D797C7FBD08D7FDEDC org.graalvm.sdk:graal-sdk:20.3.0
-8968BDBE4058F4E6610AF0DC184BD885B236A2B1 org.graalvm.sdk:launcher-common:20.3.0
+8AA4ECE060629AAAED57215A5FD8C377EFF1A191 org.graalvm.sdk:graal-sdk:24.0.0
Review Comment:
I would prefer not to rename modules, unless necessary. We can have module_auto_deps entry, I'd stick with the current name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2047806971
> The recent GraalVM for JDK21 has dropped builtin JS support, so that's fine.
I am pretty sure the graal JDK dropped everything. Languages are now regular dependencies for the application and not part of the env.
> But GraalVM for JDK17 still has js as an installable component and according to the [roadmap](https://docs.oracle.com/en/graalvm/jdk/22/docs/release-calendar/index.html#planned-releases), JDK17 as LTS is to be supported until 9/2026 ...
21, 22 does not. To plan ahead we should have test setups which work on future proof deployments. The graal debugger tests do also use far more languages than just js. The same tests use ruby, python java and js. The last bump to EOL GraalVM 11 bumped as far as possible, I literally had all releases between 11 and 21 downloaded and checked what languages they supported - since it changed from update release to update release(!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2046028378
> I'm still pondering whether it would be better to create one big "graalvm" module (this PR),
I think a big wrapper module makes sense here and would make maintenance easier I think. Updates would update the whole dependency list of the wrapper, instead of having to track them down individually. Splitting it up would be still possible later if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing closed pull request #7248: Update GraalJS to 23.0.3
URL: https://github.com/apache/netbeans/pull/7248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1559868498
##########
.github/workflows/main.yml:
##########
@@ -249,18 +249,6 @@ jobs:
- name: Commit Validation tests
run: .github/retry.sh ant $OPTS -Dcluster.config=$CLUSTER_CONFIG commit-validation
- - name: Set up JDK 11 for core.network
- uses: actions/setup-java@v4
- if: matrix.java == 17 && success()
- with:
- java-version: 11
- distribution: ${{ env.default_java_distribution }}
-
- # TODO fails on 17+
- - name: platform/core.network
- if: matrix.java == 17 && success()
- run: ant $OPTS -f platform/core.network test
-
Review Comment:
i don't want to distract from the main goal of this PR by pointing out trivialities, but the network test was under CV so that it can run on win/mac too. Is there a reason why it got moved to the linux only platform job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2048309003
> @matthiasblaesing I probably do not have enough context, sorry .... what issue was addressed by setting
>
> ```
> System.setProperty( "polyglot.engine.WarnInterpreterOnly", "false" ); //NOI18N
> ```
Truffle has excessive logging, when it is run on a JVM it does not support (without JVMCI enabled). As we are aware of that fact ant that it will take years for a JVMCI supported JVM to reach all users, it is useless to show users errors, they can do nothing about.
> ```
> System.setProperty( "truffle.UseFallbackRuntime", "true" ); //NOI18N
> ```
Without it I'm seeing this:
```
java.lang.UnsatisfiedLinkError: Native Library /home/matthias/.cache/org.graalvm.polyglot/engine/libtruffleattach/ad91dae1c5adc8f7ce79f78620596dbbdf2c86b43891cd5aff1d62d28f41429a/bin/libtruffleattach.so already loaded in another classloader
java.lang.InternalError
at com.oracle.truffle.runtime.ModulesSupport.loadModulesSupportLibrary(ModulesSupport.java:171)
at com.oracle.truffle.runtime.hotspot.HotSpotTruffleRuntimeAccess.createRuntime(HotSpotTruffleRuntimeAccess.java:84)
at com.oracle.truffle.runtime.hotspot.HotSpotTruffleRuntimeAccess.getRuntime(HotSpotTruffleRuntimeAccess.java:75)
at com.oracle.truffle.api.Truffle.createRuntime(Truffle.java:145)
at com.oracle.truffle.api.Truffle$1.run(Truffle.java:176)
at com.oracle.truffle.api.Truffle$1.run(Truffle.java:174)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
at com.oracle.truffle.api.Truffle.initRuntime(Truffle.java:174)
at com.oracle.truffle.api.impl.Accessor.getTVMCI(Accessor.java:1481)
at com.oracle.truffle.api.impl.Accessor.engineSupport(Accessor.java:1410)
at com.oracle.truffle.api.library.LibraryAccessor.engineAccessor(LibraryAccessor.java:57)
at com.oracle.truffle.api.library.LibraryFactory.loadExternalDefaultProviders(LibraryFactory.java:441)
at com.oracle.truffle.api.library.LibraryFactory.getExternalDefaultProviders(LibraryFactory.java:432)
at com.oracle.truffle.api.library.LibraryFactory.initDefaultExports(LibraryFactory.java:220)
at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:215)
at com.oracle.truffle.api.library.DynamicDispatchLibraryGen.<init>(DynamicDispatchLibraryGen.java:34)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:534)
at java.base/java.lang.Class.forName(Class.java:513)
at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:777)
at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:758)
at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:751)
at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:209)
at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:181)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:534)
at java.base/java.lang.Class.forName(Class.java:513)
at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:777)
at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:758)
at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:751)
at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:200)
at org.graalvm.polyglot.Engine.loadAndValidateProviders(Engine.java:1706)
at org.graalvm.polyglot.Engine$1.run(Engine.java:1732)
at org.graalvm.polyglot.Engine$1.run(Engine.java:1727)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1727)
at org.graalvm.polyglot.Engine.getImpl(Engine.java:442)
at org.graalvm.polyglot.Engine$Builder.build(Engine.java:740)
at org.graalvm.polyglot.Context$Builder.build(Context.java:1925)
at org.netbeans.libs.graaljs.GraalJSTest.testDirectEvaluationOfGraalJS(GraalJSTest.java:55)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:79)
at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:484)
at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:405)
at java.base/java.lang.Thread.run(Thread.java:1583)
at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:167)
at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:139)
at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2418)
at java.base/java.lang.Runtime.load0(Runtime.java:852)
at java.base/java.lang.System.load(System.java:2025)
at com.oracle.truffle.runtime.ModulesSupport.loadModulesSupportLibrary(ModulesSupport.java:168)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2061736485
Abandoned in favor of #7268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2052321651
> I do not entirely think that GraalVM is an 'exerimental' technology ...
I consider GraalVM stable once project Galahad (integration into the JDK) has happend and the first LTS JDK with that technology is out. I'm still irritated, that Nashorn was dropped before the replacement was ready.
> but anyway, I think there are still some issues:
>
> * published module (libs.truffleapi) is dropped that declares **public** packages, which might break some projects. This should be done for a reason only and if, then `module_auto_deps` should be used to maintain binary compatibility.
I ran sigtest - and the signature of the module changed in an incompatible way. So the release major version of the module would go up and thus dependencies will break anyway.
I would also assume, that it will break again in the next few years, until the technology is stable.
> * drops the possibility to go along two paths: consume JDK services and provide bundled ones; this is because drop of `libs.graalsdk.system` from the start. Reasons not well explained. If it can be fixed, it would be fair to drop this "dichotomy" when GraalVM for JDK 17 goes EOL or NB stops supporting JDK17, whichever comes first.
My reasoning: I have limited time and release of NB 22 is planed in the not too distant future. To me the question was: Support OpenJDK 22 or GraalVM 17. Supporting the current JVM is IMHO more important, that a VM with experimental extensions. This was the state I could reach with my resources. I never claimed, that it was the best/right approach.
> I'll make a parallel experiment that does not drop this ... to see if it is workable and if it is not more hacky than the current state. Conceptual issues of this approach (supporting language injection from JDK) can be discussed here.
I would prefer a better solution, so it would be great if you could come up with one. :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2041558915
23.0.3 is still broken *arg*
```
java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.ensureClassInitialized(java.lang.Class)'
at com.oracle.truffle.api.library.LibraryFactory.ensureLibraryInitialized(LibraryFactory.java:384)
at com.oracle.truffle.api.library.LibraryFactory.getUncached(LibraryFactory.java:364)
at com.oracle.truffle.api.library.LibraryFactory.<init>(LibraryFactory.java:210)
at com.oracle.truffle.api.interop.InteropLibraryGen.<init>(InteropLibraryGen.java:178)
at com.oracle.truffle.api.interop.InteropLibraryGen.<clinit>(InteropLibraryGen.java:169)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:529)
at java.base/java.lang.Class.forName(Class.java:508)
at com.oracle.truffle.api.library.LibraryFactory.loadGeneratedClass(LibraryFactory.java:791)
at com.oracle.truffle.api.library.LibraryFactory.resolveImpl(LibraryFactory.java:740)
at com.oracle.truffle.api.library.LibraryFactory.resolve(LibraryFactory.java:733)
at com.oracle.truffle.api.interop.InteropLibrary.<clinit>(InteropLibrary.java:2941)
```
What a clusterf****. Its so great, that rhino was replaced with something "better"......
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1554628214
##########
.github/workflows/main.yml:
##########
@@ -2618,9 +2618,9 @@ jobs:
- name: Setup GraalVM {{ matrix.graal }}
run: |
- URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java11-linux-amd64-${{ matrix.graal }}.tar.gz
+ URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java17-linux-amd64-${{ matrix.graal }}.tar.gz
curl -L $URL | tar -xz
- GRAALVM=`pwd`/graalvm-ce-java11-${{ matrix.graal }}
+ GRAALVM=`pwd`/graalvm-ce-java17-${{ matrix.graal }}
echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
Review Comment:
https://github.com/apache/netbeans/pull/6369 essentially bumped the version as far as possible already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#discussion_r1559531669
##########
webcommon/libs.graaljs/external/js-23.0.3-license.txt:
##########
@@ -2,8 +2,8 @@ Name: Graal SDK and Truffle API
Description: Graal SDK and Truffle API
Review Comment:
Fixed in #7253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2045601399
@sdedic thanks for taking a look! Feel free to fork. I'd also like to continue experimenting and so it would be good if you could create a separate PR.
I'm still pondering whether it would be better to create one big "graalvm" module (this PR), that exposes its API or to keep the existing modules.
What I'm not happy with in my current approach is:
- The installer that basicly disables truffle compilation: https://github.com/apache/netbeans/blob/282401359ea15eeebb679f03ae83f7f39688a6c1/ide/libs.graalsdk/src/org/netbeans/libs/graalsdk/impl/Installer.java#L14-L15
- The removal of the `.system` graal module. Here I don't know whether or not this is a problem for GraalVM images (speed/usability)
- The problems already mentioned by @lahodaj
For one problem I saw the last few days, I think I found a solution yesterday: The services of the modules need to be exported, so that they can be found by the ServiceLoader of the NetBeans module system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2040709267
Commit validation fails. All `project.properties` files will need to bump to at least Java 17.
```xml
javac.source=17
javac.target=17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2049278695
Well. Since `OpenIDE-Module-Hide-Classpath-Packages` was removed, it's no wonder that tests are failing on `GraalVM for JDK17` without `js` installed. NetBeans will load Graal SDK classes from bootstrap classpath, instead of `libs.graalsdk` - that's because the JDK does not contain Javascript, but still contains Truffle/GraalSDK implementations. Those classes have no clue about `libs.graaljs` installed in NetBeans - in fact, classloading in GraalVM was specifically changed in the past to only load JDK-installed languages.
The reason why there was originally `libs.graalsdk.system` (that relies on bootstrap classes, should they be present) and `libs.graalsdk` that tried hard to avoid bootstrap classes to load NB-provided languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2050286100
> what does "the GraalVM.js tests work only when invoked manually" mean ? `ant test` from the commandline ?
Sorry, bad wording. "the GraalVM.js tests work only when invoked manually" might be better phrased "the GraalVM.js tests work only when invoked individually". I mean, that when all tests of the GraalVM.js module are run I see 3 failing and 2 successful tests. The 3 failing tests work, when run isolated.
I think it is ok, to support GaalJS 17 only on an untested basis as the platform itself is unstable (GraalVM as a whole) or a niche (GraalVM 17). I also think it is fair, that people running such an experimental platform must be prepared to take the pain (in the case of GraalVM 17, install JS).
For a future perspective, this might become a problem:
https://github.com/apache/netbeans/blob/14fb065d23dca2fae74483b38bfe733504317c16/ide/libs.graalsdk/src/org/netbeans/libs/graalsdk/impl/Installer.java#L27-L41
But I have some hope, that in the future Truffle/GraalVM will not stay with native libraries per platform or have a sane strategy to work then without failing hard. Seeing a Java runtime loading a native library by default and calling that the future of the JVM can't be the future.
I reached the end of what I can do. I would only squash this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2051019170
@matthiasblaesing
> "the GraalVM.js tests work only when invoked individually
If you mean that you did "Run test" from the IDE on an individual **test*** method... then it's working because the module environment for the test was not properly set up in `suite()`, especially the participating classloaders. In this mode, it actually used JVM's infrastructure and implementation, not the bundled one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2048379088
I pushed an update, but I'm still not happy. With that I think this works on OpenJDK 17, 21, 22 GraalVM 21, 22 and 17 (if JS is installed).
I tested the modules:
- Scripting API
- JavaScript on JVM
- GraalVM SDK
- GraalVM.js
- core.network
on the mentioned JDKs. I trust the core.network tests, I don't trust the rest of them, especially not on GraalVM 17.
On GraalVM 17:
- the number of GraalVM SDKs tests drops from ~1050 to 295 (I assume, some dynamic method creates test cases based on languages), what is worse I had a break point after a test assert, the break point was not hit (the assert failed), but I got not test error reported.....
- the GraalVM.js tests work only when invoked manually els this is reported:
```
java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchMethodError: 'java.lang.String org.graalvm.polyglot.impl.AbstractPolyglotImpl.getTruffleVersion()' [in thread "Test Watch Dog: testDirectEvaluationOfGraalJS"]
at org.graalvm.polyglot.Engine.loadAndValidateProviders(Engine.java:1665)
at org.graalvm.polyglot.Engine$1.run(Engine.java:1732)
at org.graalvm.polyglot.Engine$1.run(Engine.java:1727)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1727)
at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:190)
at org.graalvm.polyglot.Engine.getImpl(Engine.java:442)
at org.graalvm.polyglot.Engine$Builder.build(Engine.java:740)
at org.graalvm.polyglot.Context$Builder.build(Context.java:1925)
at org.netbeans.libs.graaljs.GraalJSTest2$T.call(GraalJSTest2.java:137)
at org.netbeans.libs.graaljs.GraalJSTest2.testDirectEvaluationOfGraalJS(GraalJSTest2.java:131)
Caused: java.lang.NoClassDefFoundError: Could not initialize class org.graalvm.polyglot.Engine$ImplHolder
at org.graalvm.polyglot.Engine.getImpl(Engine.java:442)
at org.graalvm.polyglot.Engine$Builder.build(Engine.java:740)
[catch] at org.netbeans.libs.graalsdk.impl.GraalEnginesProvider.lambda$enumerateLanguages$1(GraalEnginesProvider.java:159)
at org.netbeans.libs.graalsdk.impl.GraalContext.executeWithClassLoader(GraalContext.java:117)
at org.netbeans.libs.graalsdk.impl.GraalEnginesProvider.enumerateLanguages(GraalEnginesProvider.java:157)
at org.netbeans.libs.graalsdk.impl.GraalEnginesProvider.factories(GraalEnginesProvider.java:66)
at org.netbeans.api.scripting.Scripting$EngineManager.populateExtras(Scripting.java:148)
at org.netbeans.api.scripting.Scripting$EngineManager.<init>(Scripting.java:133)
at org.netbeans.api.scripting.Scripting.build(Scripting.java:120)
at org.netbeans.api.scripting.Scripting.createManager(Scripting.java:65)
at org.netbeans.libs.graaljs.GraalJSTest2.testJavaScriptEngineIsGraalJS(GraalJSTest2.java:145)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:79)
at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:484)
at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:405)
at java.base/java.lang.Thread.run(Thread.java:842)
INFO [org.netbeans.libs.graalsdk.impl.GraalEnginesProvider]: Failed to initialize GraalEngines
java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchMethodError: 'java.lang.String org.graalvm.polyglot.impl.AbstractPolyglotImpl.getTruffleVersion()' [in thread "Test Watch Dog: testDirectEvaluationOfGraalJS"]
at org.graalvm.polyglot.Engine.loadAndValidateProviders(Engine.java:1665)
at org.graalvm.polyglot.Engine$1.run(Engine.java:1732)
at org.graalvm.polyglot.Engine$1.run(Engine.java:1727)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1727)
at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:190)
at org.graalvm.polyglot.Engine.getImpl(Engine.java:442)
at org.graalvm.polyglot.Engine$Builder.build(Engine.java:740)
at org.graalvm.polyglot.Context$Builder.build(Context.java:1925)
at org.netbeans.libs.graaljs.GraalJSTest2$T.call(GraalJSTest2.java:137)
at org.netbeans.libs.graaljs.GraalJSTest2.testDirectEvaluationOfGraalJS(GraalJSTest2.java:131)
Caused: java.lang.NoClassDefFoundError: Could not initialize class org.graalvm.polyglot.Engine$ImplHolder
at org.graalvm.polyglot.Engine.getImpl(Engine.java:442)
at org.graalvm.polyglot.Engine$Builder.build(Engine.java:740)
[catch] at org.netbeans.libs.graalsdk.impl.GraalEnginesProvider.lambda$enumerateLanguages$1(GraalEnginesProvider.java:159)
at org.netbeans.libs.graalsdk.impl.GraalContext.executeWithClassLoader(GraalContext.java:117)
at org.netbeans.libs.graalsdk.impl.GraalEnginesProvider.enumerateLanguages(GraalEnginesProvider.java:157)
at org.netbeans.libs.graalsdk.impl.GraalEnginesProvider.factories(GraalEnginesProvider.java:66)
at org.netbeans.api.scripting.Scripting$EngineManager.populateExtras(Scripting.java:148)
at org.netbeans.api.scripting.Scripting$EngineManager.<init>(Scripting.java:133)
at org.netbeans.api.scripting.Scripting.build(Scripting.java:120)
at org.netbeans.api.scripting.Scripting.createManager(Scripting.java:65)
at org.netbeans.libs.graaljs.GraalJSTest2.testDeleteASymbol(GraalJSTest2.java:158)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:79)
at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:484)
at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:405)
at java.base/java.lang.Thread.run(Thread.java:842)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update GraalJS to 23.0.3 [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #7248:
URL: https://github.com/apache/netbeans/pull/7248#issuecomment-2049385257
what does "the GraalVM.js tests work only when invoked manually" mean ? `ant test` from the commandline ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists