You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2020/02/09 20:09:51 UTC
[logging-log4j2] 02/02: LOG4J2-2777 - Add a retry count to the
Kafka Appender
This is an automated email from the ASF dual-hosted git repository.
rgoers pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit a1b952bd472d27e9b2f7ff9bcc31b00fee4c2985
Author: Ralph Goers <rg...@apache.org>
AuthorDate: Sun Feb 9 13:08:27 2020 -0700
LOG4J2-2777 - Add a retry count to the Kafka Appender
---
.../logging/log4j/core/appender/mom/kafka/KafkaAppender.java | 10 ++++++++--
src/changes/changes.xml | 3 +++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppender.java
index 03a47bf..8aa4219 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppender.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppender.java
@@ -97,6 +97,11 @@ public final class KafkaAppender extends AbstractAppender {
return asBuilder();
}
+ public B setKey(final String key) {
+ this.key = key;
+ return asBuilder();
+ }
+
public Integer getRetryCount() {
Integer intRetryCount = null;
try {
@@ -113,7 +118,8 @@ public final class KafkaAppender extends AbstractAppender {
@Deprecated
public static KafkaAppender createAppender(final Layout<? extends Serializable> layout, final Filter filter,
final String name, final boolean ignoreExceptions, final String topic, final Property[] properties,
- final Configuration configuration, final String key, final Integer retryCount) {
+ final Configuration configuration,
+ final String key) {
if (layout == null) {
AbstractLifeCycle.LOGGER.error("No layout provided for KafkaAppender");
@@ -121,7 +127,7 @@ public final class KafkaAppender extends AbstractAppender {
}
final KafkaManager kafkaManager = KafkaManager.getManager(configuration.getLoggerContext(), name, topic, true,
properties, key);
- return new KafkaAppender(name, layout, filter, ignoreExceptions, kafkaManager, null, retryCount);
+ return new KafkaAppender(name, layout, filter, ignoreExceptions, kafkaManager, null, null);
}
/**
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 5f43ffe..2094c7d 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -30,6 +30,9 @@
- "remove" - Removed
-->
<release version="2.13.1" date="2019-MM-DD" description="GA Release 2.13.1">
+ <action issue="LOG4J2-2777" dev="rgoers" type="update" due-to="joongs4">
+ Add a retry count attribute to the KafkaAppender.
+ </action>
<action issue="LOG4J2-2776" dev="rgoers" type="fix" due-to="Christoph Kaser">
An error message in RollingFileAppender uses a placeholder for the name but does not specify the name
argument in the logging call