You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/04/20 12:17:30 UTC
[GitHub] [doris] Mryange opened a new pull request, #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Mryange opened a new pull request, #18872:
URL: https://github.com/apache/doris/pull/18872
# Proposed changes
``` cpp
int64_t months = _year * 12 + _month - 1 + sign * (12 * interval.year + interval.month);
_year = months / 12;
if (_year > 9999) {
return false;
}
_month = (months % 12) + 1;
if (_day > s_days_in_month[_month]) {
_day = s_days_in_month[_month];
if (_month == 2 && doris::is_leap(_year)) {
_day++;
}
}
```
The variable "months" may be negative. Taking modulus with it (_month) may also result in a negative value, which can cause an array access overflow.
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517230021
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #18872:
URL: https://github.com/apache/doris/pull/18872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1518925446
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519386508
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519030018
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519207659
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on code in PR #18872:
URL: https://github.com/apache/doris/pull/18872#discussion_r1175246584
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1580,7 +1580,11 @@ bool VecDateTimeValue::date_add_interval(const TimeInterval& interval) {
// This will change month and year information, maybe date.
int64_t months = _year * 12 + _month - 1 + sign * (12 * interval.year + interval.month);
_year = months / 12;
- if (_year > 9999) {
+ DCHECK(months >= 0) << "months should be a non-negative number.";
Review Comment:
Also fix this in DateV2Value<T>::date_add_interval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517260002
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1516232394
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on a diff in pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on code in PR #18872:
URL: https://github.com/apache/doris/pull/18872#discussion_r1173257727
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1580,10 +1580,10 @@ bool VecDateTimeValue::date_add_interval(const TimeInterval& interval) {
// This will change month and year information, maybe date.
int64_t months = _year * 12 + _month - 1 + sign * (12 * interval.year + interval.month);
_year = months / 12;
- if (_year > 9999) {
+ if (_year < MIN_YEAR || _year > MAX_YEAR) {
return false;
}
- _month = (months % 12) + 1;
+ _month = ((_month + 11 + sign * interval.month + 12) % 12) + 1;
Review Comment:
I see a error about `runtime error: index 252 out of bounds for type 'int [13]'`
the change could cover that error ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1520190965
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517343760
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519245339
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1518925845
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517229375
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1516228830
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on a diff in pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on code in PR #18872:
URL: https://github.com/apache/doris/pull/18872#discussion_r1173304080
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1580,10 +1580,10 @@ bool VecDateTimeValue::date_add_interval(const TimeInterval& interval) {
// This will change month and year information, maybe date.
int64_t months = _year * 12 + _month - 1 + sign * (12 * interval.year + interval.month);
_year = months / 12;
- if (_year > 9999) {
+ if (_year < MIN_YEAR || _year > MAX_YEAR) {
return false;
}
- _month = (months % 12) + 1;
+ _month = ((_month + 11 + sign * interval.month + 12) % 12) + 1;
Review Comment:
now update.
In my opinion, if months is less than 0, it should be an invalid value.If we consider negative numbers as valid values, then the result of months = 5 and months = -7 will be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18872:
URL: https://github.com/apache/doris/pull/18872#discussion_r1174549867
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1580,7 +1580,11 @@ bool VecDateTimeValue::date_add_interval(const TimeInterval& interval) {
// This will change month and year information, maybe date.
int64_t months = _year * 12 + _month - 1 + sign * (12 * interval.year + interval.month);
_year = months / 12;
- if (_year > 9999) {
+ DCHECK(months>=0)<<"months should be a non-negative number.";
Review Comment:
code format the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519627331
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1520192745
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1521510575
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1521510656
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519634973
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519029433
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on a diff in pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on code in PR #18872:
URL: https://github.com/apache/doris/pull/18872#discussion_r1173262552
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1580,10 +1580,10 @@ bool VecDateTimeValue::date_add_interval(const TimeInterval& interval) {
// This will change month and year information, maybe date.
int64_t months = _year * 12 + _month - 1 + sign * (12 * interval.year + interval.month);
_year = months / 12;
- if (_year > 9999) {
+ if (_year < MIN_YEAR || _year > MAX_YEAR) {
return false;
}
- _month = (months % 12) + 1;
+ _month = ((_month + 11 + sign * interval.month + 12) % 12) + 1;
Review Comment:
Is there a error case for me to test？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517228468
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517230938
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1517260485
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18872: [fix](planner) vdatetime_value.cpp:1585 Array access may overflow.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18872:
URL: https://github.com/apache/doris/pull/18872#issuecomment-1519632110
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org