You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/06 08:08:04 UTC
[GitHub] [incubator-shardingsphere] ssxlulu opened a new issue #3878:
Refactor of datasourcefactory of shardingscaling
ssxlulu opened a new issue #3878: Refactor of datasourcefactory of shardingscaling
URL: https://github.com/apache/incubator-shardingsphere/issues/3878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3878:
Refactor of datasourceFactory of shardingscaling
Posted by GitBox <gi...@apache.org>.
KomachiSion commented on issue #3878: Refactor of datasourceFactory of shardingscaling
URL: https://github.com/apache/incubator-shardingsphere/issues/3878#issuecomment-571394224
I think `datasourceFactory` in shardingscaling now can be separated to two part.
The first part still call `datasourceFactory`, and just create datasource from configurations.
The other part refactor to `manager`, which stores and managers all datasources. Jobs or tasks should get their datasources from `manager`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #3878:
Refactor of datasourceFactory of shardingscaling
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #3878: Refactor of datasourceFactory of shardingscaling
URL: https://github.com/apache/incubator-shardingsphere/issues/3878#issuecomment-572193683
Splitting Configure and Reference with a datasource sounds like a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3878:
Refactor of datasourceFactory of shardingscaling
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #3878: Refactor of datasourceFactory of shardingscaling
URL: https://github.com/apache/incubator-shardingsphere/issues/3878#issuecomment-571055414
DatasourceFactory is a public API, We need more discuss before refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion closed issue #3878: Refactor
of datasourceFactory of shardingscaling
Posted by GitBox <gi...@apache.org>.
KomachiSion closed issue #3878: Refactor of datasourceFactory of shardingscaling
URL: https://github.com/apache/incubator-shardingsphere/issues/3878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3878:
Refactor of datasourceFactory of shardingscaling
Posted by GitBox <gi...@apache.org>.
ssxlulu commented on issue #3878: Refactor of datasourceFactory of shardingscaling
URL: https://github.com/apache/incubator-shardingsphere/issues/3878#issuecomment-571055838
> DatasourceFactory is a public API, We need more discuss before refactor.
Yes, of cource. More discuss will be needed before the refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services