You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/01/25 03:48:04 UTC
[GitHub] [incubator-doris] blackstar-baba opened a new pull request #7879: [improvement](FeMetaVersion)Some if conditions for comparing CatalogJournalVersion do not use the FeMetaVersion constant
blackstar-baba opened a new pull request #7879:
URL: https://github.com/apache/incubator-doris/pull/7879
# Proposed changes
Issue Number: close #7877
## Problem Summary:
Add multiple FeMetaVersion constants and make simple numbers point to them.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] blackstar-baba commented on pull request #7879: [improvement](FeMetaVersion)Some if conditions for comparing CatalogJournalVersion do not use the FeMetaVersion constant
Posted by GitBox <gi...@apache.org>.
blackstar-baba commented on pull request #7879:
URL: https://github.com/apache/incubator-doris/pull/7879#issuecomment-1020782685
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7879: [improvement](meta) Use meta_version constant to replace magic number when check catalog journal version
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7879:
URL: https://github.com/apache/incubator-doris/pull/7879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] blackstar-baba commented on pull request #7879: [improvement](FeMetaVersion)Some if conditions for comparing CatalogJournalVersion do not use the FeMetaVersion constant
Posted by GitBox <gi...@apache.org>.
blackstar-baba commented on pull request #7879:
URL: https://github.com/apache/incubator-doris/pull/7879#issuecomment-1021816346
@morningman PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] blackstar-baba commented on pull request #7879: [improvement](FeMetaVersion)Some if conditions for comparing CatalogJournalVersion do not use the FeMetaVersion constant
Posted by GitBox <gi...@apache.org>.
blackstar-baba commented on pull request #7879:
URL: https://github.com/apache/incubator-doris/pull/7879#issuecomment-1020782685
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7879: [improvement](FeMetaVersion)Some if conditions for comparing CatalogJournalVersion do not use the FeMetaVersion constant
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7879:
URL: https://github.com/apache/incubator-doris/pull/7879#issuecomment-1022195405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org