You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by Dave Johnson <da...@rollerweblogger.org> on 2005/11/18 20:01:36 UTC

Re: website settings page broken ... was Re: svn commit: r345303 - in /incubator/roller/trunk: src/org/roller/presentation/velocity/ src/org/roller/presentation/weblog/actions/ web/weblog/

Thanks Allen. I just committed a fix. If I had configured JSP  
compilation, I would have caught that one.

- Dave


On Nov 18, 2005, at 12:44 PM, Allen Gilliland wrote:

> this commit broke the website settings page.
>
> -- Allen
>
>
> On Thu, 2005-11-17 at 10:52, snoopdave@apache.org wrote:
>> Author: snoopdave
>> Date: Thu Nov 17 10:52:26 2005
>> New Revision: 345303
>>
>> URL: http://svn.apache.org/viewcvs?rev=345303&view=rev
>> Log:
>> Instantiate plugins on every request to resolve ROL-893 topic tag  
>> uneliable
>>
>> Modified:
>>      
>> incubator/roller/trunk/src/org/roller/presentation/velocity/ 
>> ContextLoader.java
>>      
>> incubator/roller/trunk/src/org/roller/presentation/velocity/ 
>> PageHelper.java
>>      
>> incubator/roller/trunk/src/org/roller/presentation/weblog/actions/ 
>> WeblogEntryFormAction.java
>>      
>> incubator/roller/trunk/src/org/roller/presentation/weblog/actions/ 
>> WeblogEntryPageModel.java
>>     incubator/roller/trunk/web/weblog/WeblogEdit.jsp
>>
>> ...

Re: website settings page broken ... was Re: svn commit: r345303 - in /incubator/roller/trunk: src/org/roller/presentation/velocity/ src/org/roller/presentation/weblog/actions/ web/weblog/

Posted by Dave Johnson <da...@rollerweblogger.org>.
On Nov 18, 2005, at 5:43 PM, Allen Gilliland wrote:
> yeah, jsp compilation would definitely be a handy tool.
>
> I noticed another slight problem with this fix, it now displays the 
> plugins in a randomly ordered list.  We should probably sort that 
> list.  The other tough part is that the label on the left suggests 
> that plugins are, "applied in the listed order".  I suppose that can't 
> really be considered true anymore?

That's definitely a bug. I'll make sure the original order is preserved.

- Dave

Re: website settings page broken ... was Re: svn commit: r345303 - in /incubator/roller/trunk: src/org/roller/presentation/velocity/ src/org/roller/presentation/weblog/actions/ web/weblog/

Posted by Allen Gilliland <Al...@Sun.COM>.
yeah, jsp compilation would definitely be a handy tool.

I noticed another slight problem with this fix, it now displays the plugins in a randomly ordered list.  We should probably sort that list.  The other tough part is that the label on the left suggests that plugins are, "applied in the listed order".  I suppose that can't really be considered true anymore?

-- Allen


On Fri, 2005-11-18 at 11:01, Dave Johnson wrote:
> Thanks Allen. I just committed a fix. If I had configured JSP  
> compilation, I would have caught that one.
> 
> - Dave
> 
> 
> On Nov 18, 2005, at 12:44 PM, Allen Gilliland wrote:
> 
> > this commit broke the website settings page.
> >
> > -- Allen
> >
> >
> > On Thu, 2005-11-17 at 10:52, snoopdave@apache.org wrote:
> >> Author: snoopdave
> >> Date: Thu Nov 17 10:52:26 2005
> >> New Revision: 345303
> >>
> >> URL: http://svn.apache.org/viewcvs?rev=345303&view=rev
> >> Log:
> >> Instantiate plugins on every request to resolve ROL-893 topic tag  
> >> uneliable
> >>
> >> Modified:
> >>      
> >> incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> >> ContextLoader.java
> >>      
> >> incubator/roller/trunk/src/org/roller/presentation/velocity/ 
> >> PageHelper.java
> >>      
> >> incubator/roller/trunk/src/org/roller/presentation/weblog/actions/ 
> >> WeblogEntryFormAction.java
> >>      
> >> incubator/roller/trunk/src/org/roller/presentation/weblog/actions/ 
> >> WeblogEntryPageModel.java
> >>     incubator/roller/trunk/web/weblog/WeblogEdit.jsp
> >>
> >> ...
>