You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/04/22 17:04:33 UTC

[GitHub] [arrow-rs] izveigor opened a new pull request, #4113: feat: support all primitive tensors and buffer builders

izveigor opened a new pull request, #4113:
URL: https://github.com/apache/arrow-rs/pull/4113

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4112.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   Yes
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] izveigor commented on a diff in pull request #4113: feat: support all primitive tensors and buffer builders

Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on code in PR #4113:
URL: https://github.com/apache/arrow-rs/pull/4113#discussion_r1174606767


##########
arrow/src/tensor.rs:
##########
@@ -85,17 +85,36 @@ pub struct Tensor<'a, T: ArrowPrimitiveType> {
 }
 
 pub type BooleanTensor<'a> = Tensor<'a, BooleanType>;
+pub type Date32Tensor<'a> = Tensor<'a, Date32Type>;

Review Comment:
   Golang Arrow uses Date32 tensor: https://github.com/apache/arrow/blob/main/go/arrow/tensor/numeric.gen.go#L271-L287.
   I think it might be useful to store related dates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4113: feat: support all primitive tensors and buffer builders

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4113:
URL: https://github.com/apache/arrow-rs/pull/4113#discussion_r1174473976


##########
arrow/src/tensor.rs:
##########
@@ -85,17 +85,36 @@ pub struct Tensor<'a, T: ArrowPrimitiveType> {
 }
 
 pub type BooleanTensor<'a> = Tensor<'a, BooleanType>;
+pub type Date32Tensor<'a> = Tensor<'a, Date32Type>;

Review Comment:
   What is the use-case for a tensor of dates? I was under the impression they were only for unitless quantities?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4113: Add Type Declarations for All Primitive Tensors and Buffer Builders

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4113:
URL: https://github.com/apache/arrow-rs/pull/4113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org