You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/08/27 08:19:56 UTC

Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/
-----------------------------------------------------------

Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-4482


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying no ssh key pair is assinged to VM to get the encrypted password and included a check for password enabled template


Diffs
-----

  server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 

Diff: https://reviews.apache.org/r/13842/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/#review25611
-----------------------------------------------------------


Commit 37d500d2a6b71c267af20a83208eb6049157f95f in branch refs/heads/4.2-forward from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=37d500d ]

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying no ssh key pair is assinged to VM to get the encrypted password and included a check for password enabled template

Signed-off-by: Koushik Das <ko...@apache.org>


- ASF Subversion and Git Services


On Aug. 27, 2013, 10:53 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13842/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-4482
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
> 
> Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 
> 
> Diff: https://reviews.apache.org/r/13842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/#review25614
-----------------------------------------------------------


Commit 81938c68acd3a049aa0fcb0c5ea8bc4a822d3200 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=81938c6 ]

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password.

Signed-off-by: Koushik Das <ko...@apache.org>


- ASF Subversion and Git Services


On Aug. 27, 2013, 10:53 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13842/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-4482
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
> 
> Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 
> 
> Diff: https://reviews.apache.org/r/13842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/#review25612
-----------------------------------------------------------

Ship it!


Ship It!

- Koushik Das


On Aug. 27, 2013, 10:53 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13842/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-4482
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
> 
> Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 
> 
> Diff: https://reviews.apache.org/r/13842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 10:53 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Bugs: CLOUDSTACK-4482


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password.


Diffs (updated)
-----

  server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 

Diff: https://reviews.apache.org/r/13842/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 10:51 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Bugs: CLOUDSTACK-4482


Repository: cloudstack-git


Description (updated)
-------

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password.


Diffs
-----

  server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 

Diff: https://reviews.apache.org/r/13842/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 10:42 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Bugs: CLOUDSTACK-4482


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying no ssh key pair is assinged to VM to get the encrypted password and included a check for password enabled template


Diffs (updated)
-----

  server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 

Diff: https://reviews.apache.org/r/13842/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13842/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 6:20 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Bugs: CLOUDSTACK-4482


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

Improving the error message saying no ssh key pair is assinged to VM to get the encrypted password and included a check for password enabled template


Diffs
-----

  server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f 

Diff: https://reviews.apache.org/r/13842/diff/


Testing
-------


Thanks,

Harikrishna Patnala