You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zhongneu <gi...@git.apache.org> on 2016/03/08 07:14:11 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
GitHub user zhongneu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/767
[ZEPPELIN-209] Folder structure for notebook (based on pr-190)
### What is this PR for?
This PR is based on #190
### What type of PR is it?
Feature
### Todos
* [ ] - Review
### What is the Jira issue?
[ZEPPELIN-209](https://issues.apache.org/jira/browse/ZEPPELIN-209)
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
NO
* Is there breaking changes for older versions?
NO
* Does this needs documentation?
NO? The way of creating the directory is a little bit implicit without documentation, but I am not sure about where to put documentation to...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhongneu/incubator-zeppelin test-folder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/767.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #767
----
commit 04a36f299d7e343ddcebee4424d7823f5276a0d0
Author: Zhong Wang <wa...@gmail.com>
Date: 2016-03-07T06:42:16Z
refine pr-190
commit 3a0af295d5ea19bc8f3112118af79227243fe715
Author: Zhong Wang <wa...@gmail.com>
Date: 2016-03-08T05:51:08Z
fix search box issue; fix the dropdown first elem css issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194143832
Any thoughts about; showing folders first and then files ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by zhongneu <gi...@git.apache.org>.
Github user zhongneu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-193622520
@corneadoug I've created a new pr here. Thanks for your review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194059787
@zhongneu thank you for taking a stab at bringing that feature to life again!
:+1: for screenshots, but could you please also updated PR description a bit, explaining how exactly the hierarchy is formed? Like how to create a nested structure of notebooks, and if there are any changes in how notes are persisted.
This, as well as screenshots, usually helps communicating the value of the feature and gauge people's the interest.
Also please feel free to assign [ZEPPELIN-209](https://issues.apache.org/jira/browse/ZEPPELIN-209) to yourself, so it's not get lost on the release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194102700
I think way it implements is just treating '/' in the notebook title as a directory separator in a front end side as described in [ZEPPELIN-209](https://issues.apache.org/jira/browse/ZEPPELIN-209). and it is not really related to the notebook storage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by zhongneu <gi...@git.apache.org>.
Github user zhongneu closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/767
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194061392
\cc @felizbear for a reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-209] Folder structure f...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194062568
I didn't test it yet, but I also think it could be nice to have feedbacks from people who worked on some Notebook storages. (Git, S3 etc..) @vgmartinez @khalidhuseynov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---