You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/11/26 13:28:17 UTC
Review Request 40746: Quota: Removed quota from registry for remove
request.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Joseph Wu.
Bugs: MESOS-4021
https://issues.apache.org/jira/browse/MESOS-4021
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
Diff: https://reviews.apache.org/r/40746/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40746: Quota: Removed quota from registry for
remove request.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/#review108165
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40745, 40746]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 26, 2015, 12:28 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40746/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 12:28 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-4021
> https://issues.apache.org/jira/browse/MESOS-4021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
>
> Diff: https://reviews.apache.org/r/40746/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40746: Quota: Removed quota from registry for
remove request.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/#review108712
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 26, 2015, 12:28 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40746/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 12:28 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-4021
> https://issues.apache.org/jira/browse/MESOS-4021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
>
> Diff: https://reviews.apache.org/r/40746/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40746: Quota: Removed quota from registry for
remove request.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Nov. 30, 2015, 10:47 a.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 393-394
> > <https://reviews.apache.org/r/40746/diff/1/?file=1147458#file1147458line393>
> >
> > `RemoveQuota` appears idempotent, so what is the problem with trying to remove a quota that is currently being removed?
> >
> > Is it the fact that you check this?
> > ```
> > // Check that we are removing an existing quota.
> > if (!master->quotas.contains(role)) { ... }
> > ```
>
> Alexander Rukletsov wrote:
> `RemoveQuota` is idempotent, right, but `HierarchicalAllocatorProcess::removeQuota()` is not. I think we can change the whole function to be idempotent, but is this really necessary?
No, not really.
I was just wondering what the decision behind the non-idempotency, and if it would simplify any logic by doing so :)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/#review108359
-----------------------------------------------------------
On Nov. 26, 2015, 4:28 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40746/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 4:28 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-4021
> https://issues.apache.org/jira/browse/MESOS-4021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
>
> Diff: https://reviews.apache.org/r/40746/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40746: Quota: Removed quota from registry for
remove request.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 30, 2015, 6:47 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 393-394
> > <https://reviews.apache.org/r/40746/diff/1/?file=1147458#file1147458line393>
> >
> > `RemoveQuota` appears idempotent, so what is the problem with trying to remove a quota that is currently being removed?
> >
> > Is it the fact that you check this?
> > ```
> > // Check that we are removing an existing quota.
> > if (!master->quotas.contains(role)) { ... }
> > ```
`RemoveQuota` is idempotent, right, but `HierarchicalAllocatorProcess::removeQuota()` is not. I think we can change the whole function to be idempotent, but is this really necessary?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/#review108359
-----------------------------------------------------------
On Nov. 26, 2015, 12:28 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40746/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 12:28 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-4021
> https://issues.apache.org/jira/browse/MESOS-4021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
>
> Diff: https://reviews.apache.org/r/40746/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40746: Quota: Removed quota from registry for
remove request.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40746/#review108359
-----------------------------------------------------------
Ship it!
LGTM.
src/master/quota_handler.cpp (lines 393 - 394)
<https://reviews.apache.org/r/40746/#comment167798>
`RemoveQuota` appears idempotent, so what is the problem with trying to remove a quota that is currently being removed?
Is it the fact that you check this?
```
// Check that we are removing an existing quota.
if (!master->quotas.contains(role)) { ... }
```
- Joseph Wu
On Nov. 26, 2015, 4:28 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40746/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 4:28 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
>
>
> Bugs: MESOS-4021
> https://issues.apache.org/jira/browse/MESOS-4021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp e9c8791d4bd00e6c1be1844f27d9bee26f722a9b
>
> Diff: https://reviews.apache.org/r/40746/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>