[GitHub] [rocketmq] duhenglucky commented on a change in pull request #3672: [ISSUE #3674] Improve the test cases of the tools module

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #3672:
URL: https://github.com/apache/rocketmq/pull/3672#discussion_r775238681



##########
File path: tools/src/test/java/org/apache/rocketmq/tools/command/connection/ConsumerConnectionSubCommandTest.java
##########
@@ -99,4 +69,30 @@ public void testExecute() throws SubCommandException {
             ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs, cmd.buildCommandlineOptions(options), new PosixParser());
         cmd.execute(commandLine, options, null);
     }
+
+    private ServerResponseMocker startNameServer() {

Review comment:
       there's so many startNameServer() method that exists in multiple classes， So how about putting the mock to the nameserver in the same test tool class to avoid so much duplication code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org