tomcat support

[Romain Manni-Bucau <rm...@gmail.com>]

Hi,

for the 4.0.0 should we break the tomcat 5.5 and tomcat 6.0 support?

JEE 6 needs tomcat 7 so i think we can strip a lot of ugly code.

IMHO Tomcat 6 is still used but if somebody wants to write a jee 6
application he will easily go to tomcat 7.

A user recently saw we are using a tomcat 7 specific API in the
tomcatWebappBuilder. This one can be replaced by a Tomcat6/Tomcat 7 one but
with some efforts (constructor args). I'm not sure it is useful to twist our
code like it.

What's your opinions?

- Romain

Re: tomcat support

[Jean-Louis MONTEIRO <je...@gmail.com>]

Hi Jon and al.,

regarding older tomcat version, that's more or less the same here (I mean in
our company).
That said, I'm not sure that people using older versions will want to use
Java EE 6 - Web Profile 1.0
We can still support Tomcat 6 for 3.1.x branch but get ride of it in 4.x
branch.

We started pruning unnecessary parts of OpenEJB, and IMHO supporting older
versions is more or less the same.
Finally, Tomcat 7 brings a couple of breaking features/issues, ... that have
required some important changes in event management, ...

I would be in favor of keeping the new trunk as simple as possible. If users
really need it, we can revert in the future and may be try to hack if
necessary.

Jean-Louis



2011/8/31 Jonathan Gallimore <jo...@gmail.com>

> I've been wondering that myself. I'm working on a couple of bits around the
> Tomcat integration an run into what looks like a couple of bugs in Tomcat.
> I've been wondering whether to send over a patch to Tomcat so hopefully it
> would be considered for the next release, and then going forward. The
> alternative is to work-around the issues in OpenEJB by subclassing the
> relevant Tomcat classes and wiring them into StandardContext, with the
> advantage that older Tomcat versions also get the fix. I'm still not sure
> what the right route is - currently I'm just changing what I need to, to
> prove the problem, and then I'll post up some diffs.
>
> Back to your question though - I don't think I have a particularly strong
> feeling either way. Tomcat 7 is definitely needed for TomEE to be
> webprofile
> certified, I very much doubt we could certify with Tomcat 6. I can
> definitely see some advantage to not needing to worry about supporting
> older
> versions. I just wonder how many people are using Tomcat 6 - it still seems
> to be used by a lot of the customers I work with in my day job.
>
> Jon
>
> On Wed, Aug 31, 2011 at 8:41 AM, Romain Manni-Bucau
> <rm...@gmail.com>wrote:
>
> > Hi,
> >
> > for the 4.0.0 should we break the tomcat 5.5 and tomcat 6.0 support?
> >
> > JEE 6 needs tomcat 7 so i think we can strip a lot of ugly code.
> >
> > IMHO Tomcat 6 is still used but if somebody wants to write a jee 6
> > application he will easily go to tomcat 7.
> >
> > A user recently saw we are using a tomcat 7 specific API in the
> > tomcatWebappBuilder. This one can be replaced by a Tomcat6/Tomcat 7 one
> but
> > with some efforts (constructor args). I'm not sure it is useful to twist
> > our
> > code like it.
> >
> > What's your opinions?
> >
> > - Romain
> >
>

Re: tomcat support

[Jonathan Gallimore <jo...@gmail.com>]

I've been wondering that myself. I'm working on a couple of bits around the
Tomcat integration an run into what looks like a couple of bugs in Tomcat.
I've been wondering whether to send over a patch to Tomcat so hopefully it
would be considered for the next release, and then going forward. The
alternative is to work-around the issues in OpenEJB by subclassing the
relevant Tomcat classes and wiring them into StandardContext, with the
advantage that older Tomcat versions also get the fix. I'm still not sure
what the right route is - currently I'm just changing what I need to, to
prove the problem, and then I'll post up some diffs.

Back to your question though - I don't think I have a particularly strong
feeling either way. Tomcat 7 is definitely needed for TomEE to be webprofile
certified, I very much doubt we could certify with Tomcat 6. I can
definitely see some advantage to not needing to worry about supporting older
versions. I just wonder how many people are using Tomcat 6 - it still seems
to be used by a lot of the customers I work with in my day job.

Jon

On Wed, Aug 31, 2011 at 8:41 AM, Romain Manni-Bucau
<rm...@gmail.com>wrote:

> Hi,
>
> for the 4.0.0 should we break the tomcat 5.5 and tomcat 6.0 support?
>
> JEE 6 needs tomcat 7 so i think we can strip a lot of ugly code.
>
> IMHO Tomcat 6 is still used but if somebody wants to write a jee 6
> application he will easily go to tomcat 7.
>
> A user recently saw we are using a tomcat 7 specific API in the
> tomcatWebappBuilder. This one can be replaced by a Tomcat6/Tomcat 7 one but
> with some efforts (constructor args). I'm not sure it is useful to twist
> our
> code like it.
>
> What's your opinions?
>
> - Romain
>