You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/17 18:29:20 UTC
[jira] [Commented] (CB-2063) InAppBrowser - support iPad
presentation style, iOS transition styles
[ https://issues.apache.org/jira/browse/CB-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381450#comment-15381450 ]
ASF GitHub Bot commented on CB-2063:
------------------------------------
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/176
CB-2063: (ios) Fixed presentation style
### Platforms affected
iOS
### What does this PR do?
Presentation style stopped working and this PR fix it
### What testing has been done on this change?
Tested on iPad
### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-2063-fix-transition-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 21fcc276c1bd5aa4cf8da4e8187667ff21bc0bc9
Author: Julio César <jc...@gmail.com>
Date: 2016-07-17T18:26:30Z
CB-2063: (ios) Fixed presentation style
----
> InAppBrowser - support iPad presentation style, iOS transition styles
> ---------------------------------------------------------------------
>
> Key: CB-2063
> URL: https://issues.apache.org/jira/browse/CB-2063
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin InAppBrowser
> Environment: iOS
> Reporter: Shazron Abdullah
> Assignee: jcesarmobile
> Priority: Minor
> Fix For: 2.4.0
>
>
> http://developer.apple.com/library/ios/#featuredarticles/ViewControllerPGforiPhoneOS/ModalViewControllers/ModalViewControllers.html
> Through the __options__ parameter to window.open:
> * presentationstyle=fullscreen (default)
> * presentationstyle=pagesheet
> * presentationstyle=formsheet
> * transitionstyle=coververtical (default)
> * transitionstyle=fliphorizontal
> * transitionstyle=crossdissolve
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org