[GitHub] [iotdb] Beyyes commented on a diff in pull request #11120: Enhance last query, support non single base series

["Beyyes (via GitHub)" <gi...@apache.org>]

Beyyes commented on code in PR #11120:
URL: https://github.com/apache/iotdb/pull/11120#discussion_r1323910439


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/LogicalPlanVisitor.java:
##########
@@ -619,9 +616,7 @@ public PlanNode visitShowTimeSeries(
         && null != analysis.getDataPartitionInfo()
         && 0 != analysis.getDataPartitionInfo().getDataPartitionMap().size()) {
       PlanNode lastPlanNode =
-          new LogicalPlanBuilder(analysis, context)
-              .planLast(analysis.getSourceExpressions(), analysis.getGlobalTimeFilter(), null)
-              .getRoot();
+          new LogicalPlanBuilder(analysis, context).planLast(analysis, null).getRoot();

Review Comment:
   ok, show timeseries will not step into the "if (lastQueryNonWriteViewExpressions != null) {" branch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org