You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/09 03:47:39 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #379: build: Make file extensions of assembly configurable
no1wudi opened a new pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379
## Summary
Some project (like wasm-micro-runtime) use .s instead of .S as assembly file suffix, this patch make the suffix configurable as CXXEXT
## Impact
None
## Testing
Tested on stm32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-691463018
@patacongo do you have more comment with the new approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #379: build: Make file extensions of assembly configurable
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-689302171
By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc. We need to support both .s and .S files, not one or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690000734
The build break is from sim/up_tapdev.c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690109109
> > By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc.
>
> Two issues here:
> 1.Toolchain.defs doesn't define assembler related macros(e.g. AS, ASFLAGS...).
> 2.There is no huge side effect that let *.s also pass through the preprocess.
>
> > We need to support both .s and .S files, not one or the other.
>
> How about we add a new .s rule but has the same action as .S?
In fact, asm in apps side is less common, I think it's ok otherwise the symbol in raw assembly code (.s) is dulpicated with existing pre-processor's definition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690008922
Fix here: https://github.com/apache/incubator-nuttx/pull/1743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690027656
> By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc.
Two issues here:
1.Toolchain.defs doesn't define assembler related macro(e.g. AS, ASFLAGS...).
2.There is no huge side effect that let *.s also pass through the preprocess.
> We need to support both .s and .S files, not one or the other.
How about we add a new .s rule but has the same action as .S?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi edited a comment on pull request #379: build: Make file extensions of assembly configurable
Posted by GitBox <gi...@apache.org>.
no1wudi edited a comment on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-689940987
> By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc. We need to support both .s and .S files, not one or the other.
Both .s & .S supported now,
I pass the .s file to gcc like .S, is there any problem ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-691463018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #379: build: Make file extensions of assembly configurable
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-689940987
> By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc. We need to support both .s and .S files, not one or the other.
Both .s & .S supported now,
I pass the .s file to gcc as .S, is there any problem ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-691463018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690027656
> By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc.
Two issues here:
1.Toolchain.defs doesn't define assembler related macros(e.g. AS, ASFLAGS...).
2.There is no huge side effect that let *.s also pass through the preprocess.
> We need to support both .s and .S files, not one or the other.
How about we add a new .s rule but has the same action as .S?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #379: build: Support both .s & .S
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690008922
Fix here: https://github.com/apache/incubator-nuttx/pull/1744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org