You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/01/03 23:17:55 UTC
Review Request 16588: Made ZooKeeperMasterContenderProcess::master an option
to codify the fact that it can be unset after construction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16588/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d
Diff: https://reviews.apache.org/r/16588/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 16588: Made ZooKeeperMasterContenderProcess::master an
option to codify the fact that it can be unset after construction.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16588/#review31765
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 3, 2014, 11:35 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16588/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 11:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-892
> https://issues.apache.org/jira/browse/MESOS-892
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2
> src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d
>
> Diff: https://reviews.apache.org/r/16588/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16588: Made ZooKeeperMasterContenderProcess::master an
option to codify the fact that it can be unset after construction.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16588/#review31758
-----------------------------------------------------------
Ship it!
src/master/contender.cpp
<https://reviews.apache.org/r/16588/#comment60479>
new line.
src/master/contender.cpp
<https://reviews.apache.org/r/16588/#comment60487>
return Failure instead.
- Vinod Kone
On Jan. 3, 2014, 11:35 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16588/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2014, 11:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-892
> https://issues.apache.org/jira/browse/MESOS-892
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2
> src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d
>
> Diff: https://reviews.apache.org/r/16588/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16588: Made ZooKeeperMasterContenderProcess::master an
option to codify the fact that it can be unset after construction.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16588/#review31895
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 15, 2014, 12:48 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16588/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 12:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-892
> https://issues.apache.org/jira/browse/MESOS-892
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2
> src/master/contender.cpp 72a779617139fe8ad018396014e4a2e45bd45471
>
> Diff: https://reviews.apache.org/r/16588/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 16588: Made ZooKeeperMasterContenderProcess::master an
option to codify the fact that it can be unset after construction.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16588/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 4:48 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-892
https://issues.apache.org/jira/browse/MESOS-892
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2
src/master/contender.cpp 72a779617139fe8ad018396014e4a2e45bd45471
Diff: https://reviews.apache.org/r/16588/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 16588: Made ZooKeeperMasterContenderProcess::master an
option to codify the fact that it can be unset after construction.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16588/
-----------------------------------------------------------
(Updated Jan. 3, 2014, 11:35 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-892
https://issues.apache.org/jira/browse/MESOS-892
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2
src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d
Diff: https://reviews.apache.org/r/16588/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu