You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/19 17:04:41 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3321: HDDS-6606. Rat check failure ignored for ozone-annotation-processing
adoroszlai opened a new pull request, #3321:
URL: https://github.com/apache/ozone/pull/3321
## What changes were proposed in this pull request?
* Collect rat failures from the new `dev-support/annotations` directory, too.
* Add missing license header.
* Reduce duplication by looping over the dirs to be checked.
https://issues.apache.org/jira/browse/HDDS-6606
## How was this patch tested?
Verified that the check properly fails due to license violation:
```
$ ./hadoop-ozone/dev-support/checks/rat.sh
...
dev-support/annotations/target/rat.txt: !????? src/main/java/org/apache/ozone/annotations/package-info.java
```
Then added the missing header and re-ran the check:
```
$ ./hadoop-ozone/dev-support/checks/rat.sh
...
$ echo $?
0
```
https://github.com/adoroszlai/hadoop-ozone/runs/6081893903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3321: HDDS-6606. Rat check failure ignored for ozone-annotation-processing
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3321:
URL: https://github.com/apache/ozone/pull/3321#issuecomment-1105206943
Thanks @fapifta for the kind review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3321: HDDS-6606. Rat check failure ignored for ozone-annotation-processing
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3321:
URL: https://github.com/apache/ozone/pull/3321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org