You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "VladaZakharova (via GitHub)" <gi...@apache.org> on 2024/09/06 11:28:48 UTC
[PR] Add new type of exception to catch timeout [airflow]
VladaZakharova opened a new pull request, #42064:
URL: https://github.com/apache/airflow/pull/42064
With old logic every ImportError that was raised by Timeout of reading the DAG was not stored in database and as a result, was not exposed to UI.
This PR adds additional Exception type to be catch, that will ensure that AirflowTaskTimeout exception will be also caught and stored in DB as other normal Import errors.
Closes #41976
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add new type of exception to catch timeout [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #42064:
URL: https://github.com/apache/airflow/pull/42064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add new type of exception to catch timeout [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #42064:
URL: https://github.com/apache/airflow/pull/42064#issuecomment-2345572462
Hi!
Yes, good question, thank you for pointing this out. According to my tests this exception is indeed caught and on UI we can see the output of the actual error of Timeout:

I will add a unit test for this in a separate PR
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add new type of exception to catch timeout [airflow]
Posted by "kosteev (via GitHub)" <gi...@apache.org>.
kosteev commented on PR #42064:
URL: https://github.com/apache/airflow/pull/42064#issuecomment-2345526681
I am pretty sure it works, just to double confirm.
Briefly looking the code it looks like AirflowTaskTimeout will be raised in context manager "timeout" outside of "parse" method:
https://github.com/apache/airflow/blob/f9d03151977661e2d84a0718ca2276bc6dba406c/airflow/models/dagbag.py#L381
Will be AirflowTaskTimeout be catched really by try/except in the "parse" method?
Also, would be good to have unit test for this. To prevent regression and also avoid e.g. doubts that I raise in this question:)
@VladaZakharova @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add new type of exception to catch timeout [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #42064:
URL: https://github.com/apache/airflow/pull/42064#issuecomment-2334654858
Thanks @VladaZakharova !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org