[jira] [Resolved] (AVRO-2245) Java codec testing improvements

["Nandor Kollar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nandor Kollar resolved AVRO-2245.
---------------------------------
    Resolution: Fixed

> Java codec testing improvements
> -------------------------------
>
>                 Key: AVRO-2245
>                 URL: https://issues.apache.org/jira/browse/AVRO-2245
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Jacob Tolar
>            Assignee: Jacob Tolar
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> In the Avro Java implementation, TestBZip2Codec and TestZstandardCodec are both laughably wrong.
> For example, the last lines of TestBZip2Codec:
> {code:java}
> byte[] outputByteArray = decompressedBuffer.array();
> for (int i = 0; i < inputByteSize; i++) {
>   inputByteArray[i] = outputByteArray[i];
> }
> {code}
> There should be an assertEquals in there not an assignment statement. (And if you put assertEquals there, the test actually fails...).
> I will send a PR that replaces these tests with a correct parametrized test for all codecs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)