[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24749: [SPARK-27890][SQL] Improve SQL parser error message for character-only identifier with hyphens except those in expressions

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24749: [SPARK-27890][SQL] Improve SQL parser error message for character-only identifier with hyphens except those in expressions
URL: https://github.com/apache/spark/pull/24749#discussion_r291758740
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -135,7 +137,8 @@ statement
         (ALTER | CHANGE) COLUMN? qualifiedName
         (TYPE dataType)? (COMMENT comment=STRING)? colPosition?        #alterTableColumn
     | ALTER TABLE tableIdentifier partitionSpec?
-        CHANGE COLUMN? identifier colType colPosition?                 #changeColumn
+        CHANGE COLUMN?
+        colName=errorCapturingIdentifier colType colPosition?          #changeColumn
 
 Review comment:
   @yeshengm . Since we remove the test coverage for this and this PR doesn't support this, this PR should not touch this line.
   > This is due to a recent PR on qualified column name. Fixed by removing error capture in that syntax.
   
   Could you revert this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org