You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by ar...@apache.org on 2019/10/27 06:56:43 UTC
[openoffice] 01/02: Avoid comparison between pointer and integer
This is an automated email from the ASF dual-hosted git repository.
arielch pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/openoffice.git
commit 958717d596e223826fa78462155b4447d227e5d3
Author: Ariel Constenla-Haile <ar...@apache.org>
AuthorDate: Sun Oct 27 03:43:35 2019 -0300
Avoid comparison between pointer and integer
---
main/vcl/unx/headless/svptext.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main/vcl/unx/headless/svptext.cxx b/main/vcl/unx/headless/svptext.cxx
index 21e5546..e58b65f 100644
--- a/main/vcl/unx/headless/svptext.cxx
+++ b/main/vcl/unx/headless/svptext.cxx
@@ -154,7 +154,7 @@ void SvpGlyphPeer::RemovingFont( ServerFont& )
void SvpGlyphPeer::RemovingGlyph( ServerFont&, GlyphData& rGlyphData, sal_GlyphId /*aGlyphId*/ )
{
- if( rGlyphData.ExtDataRef().mpData != Format::NONE )
+ if( rGlyphData.ExtDataRef().mpData != NULL )
{
// release the glyph related resources
DBG_ASSERT( (rGlyphData.ExtDataRef().meInfo <= Format::MAX), "SVP::RG() invalid alpha format" );
Re: [openoffice] 01/02: Avoid comparison between pointer and integer
Posted by Don Lewis <tr...@apache.org>.
On 27 Oct, arielch@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> arielch pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/openoffice.git
>
> commit 958717d596e223826fa78462155b4447d227e5d3
> Author: Ariel Constenla-Haile <ar...@apache.org>
> AuthorDate: Sun Oct 27 03:43:35 2019 -0300
>
> Avoid comparison between pointer and integer
> ---
> main/vcl/unx/headless/svptext.cxx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/main/vcl/unx/headless/svptext.cxx b/main/vcl/unx/headless/svptext.cxx
> index 21e5546..e58b65f 100644
> --- a/main/vcl/unx/headless/svptext.cxx
> +++ b/main/vcl/unx/headless/svptext.cxx
> @@ -154,7 +154,7 @@ void SvpGlyphPeer::RemovingFont( ServerFont& )
>
> void SvpGlyphPeer::RemovingGlyph( ServerFont&, GlyphData& rGlyphData, sal_GlyphId /*aGlyphId*/ )
> {
> - if( rGlyphData.ExtDataRef().mpData != Format::NONE )
> + if( rGlyphData.ExtDataRef().mpData != NULL )
> {
> // release the glyph related resources
> DBG_ASSERT( (rGlyphData.ExtDataRef().meInfo <= Format::MAX), "SVP::RG() invalid alpha format" );
>
This code is actually more deeply broken. A while ago I started
investigating a patch, but I have absolutely no idea of how to test it.
I think I sent a message to the list at the time.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [openoffice] 01/02: Avoid comparison between pointer and integer
Posted by Don Lewis <tr...@apache.org>.
On 27 Oct, arielch@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> arielch pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/openoffice.git
>
> commit 958717d596e223826fa78462155b4447d227e5d3
> Author: Ariel Constenla-Haile <ar...@apache.org>
> AuthorDate: Sun Oct 27 03:43:35 2019 -0300
>
> Avoid comparison between pointer and integer
> ---
> main/vcl/unx/headless/svptext.cxx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/main/vcl/unx/headless/svptext.cxx b/main/vcl/unx/headless/svptext.cxx
> index 21e5546..e58b65f 100644
> --- a/main/vcl/unx/headless/svptext.cxx
> +++ b/main/vcl/unx/headless/svptext.cxx
> @@ -154,7 +154,7 @@ void SvpGlyphPeer::RemovingFont( ServerFont& )
>
> void SvpGlyphPeer::RemovingGlyph( ServerFont&, GlyphData& rGlyphData, sal_GlyphId /*aGlyphId*/ )
> {
> - if( rGlyphData.ExtDataRef().mpData != Format::NONE )
> + if( rGlyphData.ExtDataRef().mpData != NULL )
> {
> // release the glyph related resources
> DBG_ASSERT( (rGlyphData.ExtDataRef().meInfo <= Format::MAX), "SVP::RG() invalid alpha format" );
>
This code is actually more deeply broken. A while ago I started
investigating a patch, but I have absolutely no idea of how to test it.
I think I sent a message to the list at the time.