You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/10 09:20:21 UTC
[GitHub] [maven-shared-utils] pzygielo opened a new pull request #55: Remove unused containers
pzygielo opened a new pull request #55:
URL: https://github.com/apache/maven-shared-utils/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] pzygielo edited a comment on pull request #55: Remove unused containers
Posted by GitBox <gi...@apache.org>.
pzygielo edited a comment on pull request #55:
URL: https://github.com/apache/maven-shared-utils/pull/55#issuecomment-642075373
> The problem is, they are public.
1. `DocHandler` is inner and *private*, so I believe its method were not exposed for public consumption.
2. Methods already inherited from `DefaultHandler` do the same (nothing if considered that `warnings`/`errors`/`fatals` are not used).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] michael-o commented on pull request #55: Remove unused containers
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #55:
URL: https://github.com/apache/maven-shared-utils/pull/55#issuecomment-642104768
@elharo Any opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] michael-o commented on pull request #55: Remove unused containers
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #55:
URL: https://github.com/apache/maven-shared-utils/pull/55#issuecomment-642033445
The problem is, they are public. I think they should be deprecated or we need to add getters for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] asfgit closed pull request #55: Remove unused containers
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #55:
URL: https://github.com/apache/maven-shared-utils/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] pzygielo commented on pull request #55: Remove unused containers
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #55:
URL: https://github.com/apache/maven-shared-utils/pull/55#issuecomment-642075373
> The problem is, they are public.
1. `DocHandler` is inner and *private*, so I believe its method were not exposed for public consumption.
2. Methods already iherited from `DefaultHandler` do the same (nothing if considered that `warnings`/`errors`/`fatals` are not used).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org