You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/09/03 10:16:16 UTC

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/64

    CB-9605 Fixes issue with playback resume after pause on WP8

    This fixes [CB-9605](https://issues.apache.org/jira/browse/CB-9605)
    
    In case of playing remote file, specified by URL (instead of local path) `player.Source.AbsolutePath` is a last part of original URL and thus `AbsolutePath.LastIndexOf(filePath)` always -1:
    
        AbsoluteUri = "http://cordova.apache.org/downloads/BlueZedEx.mp3"
        AbsolutePath = "/downloads/BlueZedEx.mp3"
    
    So, using an `AbsoluteUri` looks more reasonable and works for both local files and remote URLs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-9605

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit 71af3b1c302d4adfffb2616a60e95c4ca94d3046
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2015-09-03T08:07:17Z

    CB-9605 Fixes issue with playback resume after pause on WP8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-media/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9605 Fixes issue with playba...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-media/pull/64#issuecomment-137533398
  
    LGTM!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org