[GitHub] [airflow] uranusjr commented on a diff in pull request #23105: Catch Fernet decode error in Connection

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #23105:
URL: https://github.com/apache/airflow/pull/23105#discussion_r853819527


##########
airflow/models/connection.py:
##########
@@ -278,16 +287,10 @@ def password(cls):
         """Password. The value is decrypted/encrypted when reading/setting the value."""
         return synonym('_password', descriptor=property(cls.get_password, cls.set_password))
 
-    def get_extra(self) -> Dict:
+    def get_extra(self) -> Optional[str]:

Review Comment:
   No this should be str to begin with; this function is used to construct the declared_attr `extra`, which is in turn used to construct the property `extra_dejson`:
   
   https://github.com/apache/airflow/blob/501a3c3fbefbcc0d6071a00eb101110fc4733e08/airflow/models/connection.py#L394=L408
   
   It should be quite obvious `extra` can’t be a dict from how this property is implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org