svn commit: r1377971 - in /lucene/dev/branches/branch_4x: ./ dev-tools/ dev-tools/scripts/checkJavaDocs.py

[rm...@apache.org]

Author: rmuir
Date: Tue Aug 28 04:06:00 2012
New Revision: 1377971

URL: http://svn.apache.org/viewvc?rev=1377971&view=rev
Log:
generics-proof this

Modified:
    lucene/dev/branches/branch_4x/   (props changed)
    lucene/dev/branches/branch_4x/dev-tools/   (props changed)
    lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py

Modified: lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py?rev=1377971&r1=1377970&r2=1377971&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py (original)
+++ lucene/dev/branches/branch_4x/dev-tools/scripts/checkJavaDocs.py Tue Aug 28 04:06:00 2012
@@ -28,7 +28,7 @@ reColOne = re.compile('<td class="colOne
 
 # the Method detail section at the end
 reMethodDetail = re.compile('^<h3>Method Detail</h3>$', re.IGNORECASE)
-reMethodDetailAnchor = re.compile('^<a name="([^>]*?)">$', re.IGNORECASE)
+reMethodDetailAnchor = re.compile('^(</a>)?<a name="([^>]*?)">$', re.IGNORECASE)
 reMethodOverridden = re.compile('^<dt><strong>(Specified by:|Overrides:)</strong></dt>$', re.IGNORECASE)
 
 def cleanHTML(s):
@@ -65,7 +65,7 @@ def checkClass(fullPath):
     if foundMethodDetail:
       m = reMethodDetailAnchor.search(line)
       if m is not None:
-        lastMethodAnchor = m.group(1)
+        lastMethodAnchor = m.group(2)
         continue
       m = reMethodOverridden.search(line)
       if m is not None and ('Methods', lastMethodAnchor) in missing:
@@ -85,9 +85,6 @@ def checkClass(fullPath):
       m = reTDLast.search(line)
       if m is not None:
         # methods etc
-        # TODO: this is actually the link anchor for the method, which we must
-        # somehow defer and only later check if the list at that anchor does not contain
-        # the text 'specified by' (in which case its an overridden method from an external library)
         lastItem = m.group(1)
       else:
         # ctors etc