You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/03/18 07:56:34 UTC

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #102: [IOTDB-33] Test Apache-Rat check on Windows + Oracle JDK8/11, and Lin…

jixuan1989 commented on issue #102: [IOTDB-33] Test Apache-Rat check on Windows + Oracle JDK8/11, and Lin…
URL: https://github.com/apache/incubator-iotdb/pull/102#issuecomment-473805656
 
 
   I think... if we omit too many files by using `-Drat.numUnapprovedLicenses`, why we run apache-rat check? 
   (We run this for avoiding some new added files lack the Apache header. But, in this way, these files will be omitted..)
   Therefore, if `-Drat.numUnapprovedLicenses` is the solution, I think it equals to *skip to run `mvn apache-rat:check`*.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services