[jira] [Commented] (CALCITE-2772) Support varargs for user-defined functions (UDFs)

["Danny Chan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930390#comment-16930390 ] 

Danny Chan commented on CALCITE-2772:
-------------------------------------

Let me repeat the review comments again:

Before the review start, can you share your cases why we need to support variable arguments for UDF/UDAF/UDTF ? We have already declare multiple number of arguments when registering the functions into the catalog.

For example, we can declare both my_udf(string, string) and my_udf(string, string, string), so do we really need to support freely variable length argument functions ?

> Support varargs for user-defined functions (UDFs)
> -------------------------------------------------
>
>                 Key: CALCITE-2772
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2772
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: pengzhiwei
>            Assignee: pengzhiwei
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: support_varargs_udf.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Support varargs for user-defined functions as the case followed:
> {code:java}
> public class ConcatWs {
>   public String eval(String sep, String... strs) {...}
> }{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)