You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2017/02/07 20:30:27 UTC
[VOTE] Release Apache Tomcat Native 1.2.11
Version 1.2.10 includes the following change:
- Update minimum recommended OpenSSL version to 1.0.2k
- Windows binaries built with OpenSSL 1.0.2k
- Better documentation for building on Windows
(including with FIPS enabled OpenSSL)
The proposed release artefacts can be found at [1],
and the build was done using tag [2].
The Apache Tomcat Native 1.2.11 is
[ ] Stable, go ahead and release
[ ] Broken because of ...
Thanks,
Mark
[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.11/
[2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_11
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.2.11
Posted by Violeta Georgieva <vi...@apache.org>.
Hi,
2017-02-07 22:30 GMT+02:00 Mark Thomas <ma...@apache.org>:
>
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
> (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...
OS Windows 7
Loaded APR based Apache Tomcat Native library 1.2.11 using APR version
1.5.2.
OpenSSL successfully initialized (OpenSSL 1.0.2k 26 Jan 2017)
Tomcat 6 trunk, APR tests, JDK jdk1.5.0_22 - successful
Tomcat 7 trunk, APR tests, JDK jdk1.6.0_45 - successful
Tomcat 8 trunk, APR tests, JDK jdk1.7.0_80 - successful
Tomcat 8.5 trunk, APR tests, JDK jdk1.7.0_80 - successful
Tomcat 9 trunk, APR tests, JDK jdk1.8.0_101 - successful
Regards,
Violeta
> Thanks,
>
> Mark
>
>
> [1]
>
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.11/
> [2]
https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_11
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: [VOTE] Release Apache Tomcat Native 1.2.11
Posted by Mark Thomas <ma...@apache.org>.
On 9 February 2017 15:29:20 GMT+00:00, therealneworld@gmail.com wrote:
>On Wed, Feb 8, 2017 at 6:17 PM, Mark Thomas <ma...@apache.org> wrote:
>> On 07/02/17 20:30, Mark Thomas wrote:
>>>
>>> Version 1.2.10 includes the following change:
>>>
>>> - Update minimum recommended OpenSSL version to 1.0.2k
>>> - Windows binaries built with OpenSSL 1.0.2k
>>> - Better documentation for building on Windows
>>> (including with FIPS enabled OpenSSL)
>>>
>>> The proposed release artefacts can be found at [1],
>>> and the build was done using tag [2].
>>>
>>> The Apache Tomcat Native 1.2.11 is
>>> [ ] Stable, go ahead and release
>>> [X] Broken because of ...
>>
>>
>> I'm seeing intermittent crashes in the in the unit tests on Windows.
>>
>> As far as I can tell it is caused by the following:
>> - test 1 ends
>> - test 1 shuts down APR
>> - not all test 1 threads complete
>> - test 2 starts
>> - remaining test 1 threads complete
>> - remaining test 1 threads try to clean up thread-local memory
>> - crash as this memory was cleaned-up when APR for test 1 was shut
>down
>>
>> Liberal use of #if to remove all references to APR thread locals for
>the
>> Windows code and calling the OpenSSL clean-up directly seems to fix
>it.
>>
>> I am therefore cancelling this release vote.
>>
>> I should have a new RC ready in ~ 12 hours.
>>
>> Sorry for not spotting the problem sooner.
>>
>
>I think the issue might have been in my original patch independent of
>OS. Looking at it again I think the initialization of the thread local
>should have been wrapped in something like apr_thread_once. However, I
>am not exactly sure how to correctly use the apr thread once api. It
>looks like you must first initialize the control using
>apr_thread_once_init however that does not have any safety preventing
>it from being called multiple times so I am not sure where that could
>be safely invoked, so that it is called once during the life of the
>process.
>
>On Linux I think it is not causing a major problem because the pthread
>thread local is just being initialized to a new slot so it is using
>extra thread local slots but doesn't cause crashes.
>
>Sorry, about that over site.
No problem. One extra slot per thread is not a big deal.
We (OK, you :) ) can clean this up some more for the next release.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.2.11
Posted by th...@gmail.com.
On Wed, Feb 8, 2017 at 6:17 PM, Mark Thomas <ma...@apache.org> wrote:
> On 07/02/17 20:30, Mark Thomas wrote:
>>
>> Version 1.2.10 includes the following change:
>>
>> - Update minimum recommended OpenSSL version to 1.0.2k
>> - Windows binaries built with OpenSSL 1.0.2k
>> - Better documentation for building on Windows
>> (including with FIPS enabled OpenSSL)
>>
>> The proposed release artefacts can be found at [1],
>> and the build was done using tag [2].
>>
>> The Apache Tomcat Native 1.2.11 is
>> [ ] Stable, go ahead and release
>> [X] Broken because of ...
>
>
> I'm seeing intermittent crashes in the in the unit tests on Windows.
>
> As far as I can tell it is caused by the following:
> - test 1 ends
> - test 1 shuts down APR
> - not all test 1 threads complete
> - test 2 starts
> - remaining test 1 threads complete
> - remaining test 1 threads try to clean up thread-local memory
> - crash as this memory was cleaned-up when APR for test 1 was shut down
>
> Liberal use of #if to remove all references to APR thread locals for the
> Windows code and calling the OpenSSL clean-up directly seems to fix it.
>
> I am therefore cancelling this release vote.
>
> I should have a new RC ready in ~ 12 hours.
>
> Sorry for not spotting the problem sooner.
>
I think the issue might have been in my original patch independent of
OS. Looking at it again I think the initialization of the thread local
should have been wrapped in something like apr_thread_once. However, I
am not exactly sure how to correctly use the apr thread once api. It
looks like you must first initialize the control using
apr_thread_once_init however that does not have any safety preventing
it from being called multiple times so I am not sure where that could
be safely invoked, so that it is called once during the life of the
process.
On Linux I think it is not causing a major problem because the pthread
thread local is just being initialized to a new slot so it is using
extra thread local slots but doesn't cause crashes.
Sorry, about that over site.
-nate
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[VOTE][CANCELLED] Release Apache Tomcat Native 1.2.11
Posted by Mark Thomas <ma...@apache.org>.
I'm cancelling this vote due to the JVM crashes I observed with 1.2.11
and the 9.0.x unit tests with APR/native on Windows.
Mark
On 08/02/17 23:17, Mark Thomas wrote:
> On 07/02/17 20:30, Mark Thomas wrote:
>> Version 1.2.10 includes the following change:
>>
>> - Update minimum recommended OpenSSL version to 1.0.2k
>> - Windows binaries built with OpenSSL 1.0.2k
>> - Better documentation for building on Windows
>> (including with FIPS enabled OpenSSL)
>>
>> The proposed release artefacts can be found at [1],
>> and the build was done using tag [2].
>>
>> The Apache Tomcat Native 1.2.11 is
>> [ ] Stable, go ahead and release
>> [X] Broken because of ...
>
> I'm seeing intermittent crashes in the in the unit tests on Windows.
>
> As far as I can tell it is caused by the following:
> - test 1 ends
> - test 1 shuts down APR
> - not all test 1 threads complete
> - test 2 starts
> - remaining test 1 threads complete
> - remaining test 1 threads try to clean up thread-local memory
> - crash as this memory was cleaned-up when APR for test 1 was shut down
>
> Liberal use of #if to remove all references to APR thread locals for the
> Windows code and calling the OpenSSL clean-up directly seems to fix it.
>
> I am therefore cancelling this release vote.
>
> I should have a new RC ready in ~ 12 hours.
>
> Sorry for not spotting the problem sooner.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.2.11
Posted by Mark Thomas <ma...@apache.org>.
On 07/02/17 20:30, Mark Thomas wrote:
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
> (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
> [ ] Stable, go ahead and release
> [X] Broken because of ...
I'm seeing intermittent crashes in the in the unit tests on Windows.
As far as I can tell it is caused by the following:
- test 1 ends
- test 1 shuts down APR
- not all test 1 threads complete
- test 2 starts
- remaining test 1 threads complete
- remaining test 1 threads try to clean up thread-local memory
- crash as this memory was cleaned-up when APR for test 1 was shut down
Liberal use of #if to remove all references to APR thread locals for the
Windows code and calling the OpenSSL clean-up directly seems to fix it.
I am therefore cancelling this release vote.
I should have a new RC ready in ~ 12 hours.
Sorry for not spotting the problem sooner.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.2.11
Posted by th...@gmail.com.
On Tue, Feb 7, 2017 at 3:30 PM, Mark Thomas <ma...@apache.org> wrote:
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
> (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...
>
> Thanks,
>
> Mark
>
Tested on Linux and works well for me.
-nate
>
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.11/
> [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_11
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.2.11
Posted by Rémy Maucherat <re...@apache.org>.
2017-02-07 21:30 GMT+01:00 Mark Thomas <ma...@apache.org>:
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
> (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...
>
Tested on Linux, where everything is always good, though.
Rémy
>
> Thanks,
>
> Mark
>
>
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connect
> ors/native/1.2.11/
> [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_N
> ATIVE_1_2_11
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>