You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/08/04 15:54:55 UTC

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/987

    [FLINk-1680] Remove Tachyon test, rename maven module

    I removed our dependencies to Tachyon.
    The Tachyon test cluster (version 0.5) seemed to be unstable.
    Upgrading to Tachyon 0.7 was causing some dependency issues with Hadoop.
    
    Since the "flink-tachyon" module never contained any special code for Tachyon, I just removed the Tachyon test. 
    There is still a (very stable) test using the HDFS mini cluster to verify that our file system abstractions are working properly

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink1680

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/987.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #987
    
----
commit 7d9da868b9ce38b0a5796577f1ba2bc280f0b71e
Author: Robert Metzger <rm...@apache.org>
Date:   2015-08-04T11:35:12Z

    [FLINk-1680] Remove Tachyon test, rename maven module to "flink-fs-tests"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/987#issuecomment-127970460
  
    OK, will merge this one as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/987


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/987#issuecomment-127636475
  
    The problem is that we can only include this module for the hadoop2 builds. Therefore, I can not add the code to a module which is always present (`flink-tests`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/987#issuecomment-127629178
  
    Looks good in general.
    
    Any reason that the tests cannot be part of `flink-tests`? Just thinking that we may reduce our maven project sprawl a bit ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/987#issuecomment-127968310
  
    I see, makes sense...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINk-1680] Remove Tachyon test, rename maven...

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/987#issuecomment-127634823
  
    +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---