You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/14 04:29:08 UTC
[GitHub] [arrow] emkornfield opened a new pull request #8184: ARROW-8678: [C++/Python][Parquet] Remove old writer code path
emkornfield opened a new pull request #8184:
URL: https://github.com/apache/arrow/pull/8184
The new code has been the default for 2 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #8184: ARROW-8678: [C++/Python][Parquet] Remove old writer code path
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #8184:
URL: https://github.com/apache/arrow/pull/8184#discussion_r488361608
##########
File path: python/pyarrow/parquet.py
##########
@@ -555,7 +550,7 @@ def __init__(self, where, schema, filesystem=None,
else:
sink = where
self._metadata_collector = options.pop('metadata_collector', None)
- engine_version = os.environ.get('ARROW_PARQUET_WRITER_ENGINE', 'V2')
Review comment:
thanks. removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield closed pull request #8184: ARROW-8678: [C++/Python][Parquet] Remove old writer code path
Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #8184:
URL: https://github.com/apache/arrow/pull/8184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8184: ARROW-8678: [C++/Python][Parquet] Remove old writer code path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8184:
URL: https://github.com/apache/arrow/pull/8184#issuecomment-691804014
https://issues.apache.org/jira/browse/ARROW-8678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #8184: ARROW-8678: [C++/Python][Parquet] Remove old writer code path
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8184:
URL: https://github.com/apache/arrow/pull/8184#issuecomment-694352200
going to merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8184: ARROW-8678: [C++/Python][Parquet] Remove old writer code path
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #8184:
URL: https://github.com/apache/arrow/pull/8184#discussion_r487764240
##########
File path: python/pyarrow/parquet.py
##########
@@ -555,7 +550,7 @@ def __init__(self, where, schema, filesystem=None,
else:
sink = where
self._metadata_collector = options.pop('metadata_collector', None)
- engine_version = os.environ.get('ARROW_PARQUET_WRITER_ENGINE', 'V2')
Review comment:
There is another occurrence of this in ``_dataset.pyx`` now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org