You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/02/20 10:11:39 UTC

[kudu-CR] [docs] Fix table name in Impala docs 

Hello Will Berkeley, Alex Rodoni,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12534

to review the following change.


Change subject: [docs] Fix table name in Impala docs
......................................................................

[docs] Fix table name in Impala docs

Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/12534/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12534/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

http://gerrit.cloudera.org:8080/#/c/12534/1/docs/kudu_impala_integration.adoc@231
PS1, Line 231: impala::database_name.table_name
> Maybe, it makes sense to mention under which name the table is visible/addr
Elaborated on it, is this what you meant?



-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 21:35:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12534/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

http://gerrit.cloudera.org:8080/#/c/12534/1/docs/kudu_impala_integration.adoc@231
PS1, Line 231: impala::database_name.table_name
Maybe, it makes sense to mention under which name the table is visible/addressable in Kudu and Impala.  What do you think?

The specified  `impala::database_name.table_name` is how the table can be addressed in Kudu, right?  What about Impala itself?  That's `database_name.table_name` right?



-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 15:31:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12534

to look at the new patch set (#3).

Change subject: [docs] Fix table name in Impala docs
......................................................................

[docs] Fix table name in Impala docs

Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
---
M docs/kudu_impala_integration.adoc
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/12534/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12534/3/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

http://gerrit.cloudera.org:8080/#/c/12534/3/docs/kudu_impala_integration.adoc@232
PS3, Line 232: follow,
> follow
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 11:47:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12534

to look at the new patch set (#2).

Change subject: [docs] Fix table name in Impala docs
......................................................................

[docs] Fix table name in Impala docs

Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
---
M docs/kudu_impala_integration.adoc
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/12534/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12534

to look at the new patch set (#4).

Change subject: [docs] Fix table name in Impala docs
......................................................................

[docs] Fix table name in Impala docs

Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
---
M docs/kudu_impala_integration.adoc
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/12534/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................

[docs] Fix table name in Impala docs

Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Reviewed-on: http://gerrit.cloudera.org:8080/12534
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/kudu_impala_integration.adoc
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Will Berkeley: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 17:32:31 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12534/3/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

http://gerrit.cloudera.org:8080/#/c/12534/3/docs/kudu_impala_integration.adoc@232
PS3, Line 232: folllow
follow



-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 19:18:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 2:

(1 comment)

LGTM, just a tiny nit.

Thanks for clarifying on that!

http://gerrit.cloudera.org:8080/#/c/12534/2/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:

http://gerrit.cloudera.org:8080/#/c/12534/2/docs/kudu_impala_integration.adoc@232
PS2, Line 232: folllows separated by a
             : dot.
typo and style nit: follow, separated by a dot.



-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:07:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Fix table name in Impala docs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12534 )

Change subject: [docs] Fix table name in Impala docs
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39866cfc810731e26592ddffd9a328bc8380f46e
Gerrit-Change-Number: 12534
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 06:38:24 +0000
Gerrit-HasComments: No